Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: pkg/analysis_server/lib/src/operation/operation_analysis.dart

Issue 1432423004: Send any logError() information to the IDE. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/operation/operation_analysis.dart
diff --git a/pkg/analysis_server/lib/src/operation/operation_analysis.dart b/pkg/analysis_server/lib/src/operation/operation_analysis.dart
index 1e430d500850906c5e4bc6b21a21e0c68c97cfed..93a9bf233876618577c139ebea97e5e015cc05dc 100644
--- a/pkg/analysis_server/lib/src/operation/operation_analysis.dart
+++ b/pkg/analysis_server/lib/src/operation/operation_analysis.dart
@@ -276,7 +276,7 @@ void _sendNotification(AnalysisServer server, f()) {
try {
f();
} catch (exception, stackTrace) {
- server.sendServerErrorNotification(exception, stackTrace);
+ server.sendServerErrorNotification(null, exception, stackTrace);
}
});
}
@@ -418,7 +418,7 @@ class PerformAnalysisOperation extends ServerOperation {
scheduleIndexOperation(server, file, dartUnit);
}
} catch (exception, stackTrace) {
- server.sendServerErrorNotification(exception, stackTrace);
+ server.sendServerErrorNotification(null, exception, stackTrace);
}
// HTML
try {
@@ -427,7 +427,7 @@ class PerformAnalysisOperation extends ServerOperation {
server.addOperation(new _HtmlIndexOperation(context, file, htmlUnit));
}
} catch (exception, stackTrace) {
- server.sendServerErrorNotification(exception, stackTrace);
+ server.sendServerErrorNotification(null, exception, stackTrace);
}
}
}
@@ -463,7 +463,7 @@ class _DartIndexOperation extends _SingleFileOperation {
AnalysisContext context = unit.element.context;
index.index(context, unit);
} catch (exception, stackTrace) {
- server.sendServerErrorNotification(exception, stackTrace);
+ server.sendServerErrorNotification(null, exception, stackTrace);
}
});
}

Powered by Google App Engine
This is Rietveld 408576698