chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac_unittest.mm - Issue 1432403003: Do not call stat() when reading directories via File API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac_unittest.mm

Issue 1432403003: Do not call stat() when reading directories via File API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Whitespace cleanup. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media_galleries/linux/mtp_device_task_helper.cc ('K') | « chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac.mm ('k') | chrome/browser/media_galleries/win/mtp_device_delegate_impl_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac_unittest.mm

diff --git a/chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac_unittest.mm b/chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac_unittest.mm

index 7c8deb47ff7451f24f3dd559f8de17f006a40efe..e418d650bbd70f40519b3691b55c2f7ff71e513b 100644

--- a/chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac_unittest.mm

+++ b/chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac_unittest.mm

@@ -400,11 +400,9 @@ TEST_F(MTPDeviceDelegateImplMacTest, TestGetFileInfo) {

EXPECT_EQ(base::File::FILE_OK, ReadDir(base::FilePath(kDevicePath)));

ASSERT_EQ(2U, file_list_.size());

- EXPECT_EQ(time1, file_list_[0].last_modified_time);

EXPECT_FALSE(file_list_[0].is_directory);

EXPECT_EQ("name1", file_list_[0].name);

- EXPECT_EQ(time1, file_list_[1].last_modified_time);

EXPECT_FALSE(file_list_[1].is_directory);

EXPECT_EQ("name2", file_list_[1].name);

}

@@ -433,11 +431,9 @@ TEST_F(MTPDeviceDelegateImplMacTest, TestDirectoriesAndSorting) {

ASSERT_EQ(4U, file_list_.size());

EXPECT_EQ("dir1", file_list_[0].name);

EXPECT_EQ("dir2", file_list_[1].name);

- EXPECT_EQ(time1, file_list_[2].last_modified_time);

EXPECT_FALSE(file_list_[2].is_directory);

EXPECT_EQ("name1", file_list_[2].name);

- EXPECT_EQ(time1, file_list_[3].last_modified_time);

EXPECT_FALSE(file_list_[3].is_directory);

EXPECT_EQ("name2", file_list_[3].name);

}