content/browser/fileapi/dragged_file_util_unittest.cc - Issue 1432403003: Do not call stat() when reading directories via File API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/fileapi/dragged_file_util_unittest.cc

Issue 1432403003: Do not call stat() when reading directories via File API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed FSP tests. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js ('k') | storage/browser/fileapi/async_file_util_adapter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/fileapi/dragged_file_util_unittest.cc

diff --git a/content/browser/fileapi/dragged_file_util_unittest.cc b/content/browser/fileapi/dragged_file_util_unittest.cc

index 38d83374baa31dfd6ac0f9e98229f65e31c95515..398ce6d1a05cdcb132df06b8ceed77336a7e5c5d 100644

--- a/content/browser/fileapi/dragged_file_util_unittest.cc

+++ b/content/browser/fileapi/dragged_file_util_unittest.cc

@@ -374,8 +374,6 @@ TEST_F(DraggedFileUtilTest, ReadDirectoryTest) {

storage::DirectoryEntry entry;

entry.is_directory = file_info.IsDirectory();

entry.name = current.BaseName().value();

- entry.size = file_info.GetSize();

- entry.last_modified_time = file_info.GetLastModifiedTime();

expected_entry_map[entry.name] = entry;

#if defined(OS_POSIX)

@@ -403,9 +401,6 @@ TEST_F(DraggedFileUtilTest, ReadDirectoryTest) {

EXPECT_TRUE(found != expected_entry_map.end());

EXPECT_EQ(found->second.name, entry.name);

EXPECT_EQ(found->second.is_directory, entry.is_directory);

- EXPECT_EQ(found->second.size, entry.size);

- EXPECT_EQ(found->second.last_modified_time.ToDoubleT(),

- entry.last_modified_time.ToDoubleT());

}