Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1607)

Unified Diff: chrome/browser/media_galleries/fileapi/picasa_file_util_unittest.cc

Issue 1432403003: Do not call stat() when reading directories via File API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed FSP tests. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media_galleries/fileapi/picasa_file_util_unittest.cc
diff --git a/chrome/browser/media_galleries/fileapi/picasa_file_util_unittest.cc b/chrome/browser/media_galleries/fileapi/picasa_file_util_unittest.cc
index 6b597e48ba1befeb951ca45dc5a397bc14cd6261..8b1c080ec352b7f20422436baea76ecef04667ce 100644
--- a/chrome/browser/media_galleries/fileapi/picasa_file_util_unittest.cc
+++ b/chrome/browser/media_galleries/fileapi/picasa_file_util_unittest.cc
@@ -303,12 +303,6 @@ class PicasaFileUtilTest : public testing::Test {
for (size_t i = 0; i < contents.size(); ++i) {
EXPECT_TRUE(contents[i].is_directory);
- // Because the timestamp is written out as a floating point Microsoft
- // variant time, we only expect it to be accurate to within a second.
- base::TimeDelta delta = test_folders[i]->folder_info().timestamp -
- contents[i].last_modified_time;
- EXPECT_LT(delta, base::TimeDelta::FromSeconds(1));
-
FileSystemOperation::FileEntryList folder_contents;
FileSystemURL folder_url = CreateURL(
std::string(kPicasaDirFolders) + "/" +
@@ -441,7 +435,6 @@ TEST_F(PicasaFileUtilTest, NameDeduplication) {
for (size_t i = 0; i < contents.size(); ++i) {
EXPECT_EQ(expected_names[i],
base::FilePath(contents[i].name).AsUTF8Unsafe());
- EXPECT_EQ(test_folders[i]->timestamp(), contents[i].last_modified_time);
EXPECT_TRUE(contents[i].is_directory);
}
}
@@ -461,9 +454,6 @@ TEST_F(PicasaFileUtilTest, RootFolders) {
EXPECT_TRUE(contents.front().is_directory);
EXPECT_TRUE(contents.back().is_directory);
- EXPECT_EQ(0, contents.front().size);
- EXPECT_EQ(0, contents.back().size);
-
EXPECT_EQ(FILE_PATH_LITERAL("albums"), contents.front().name);
EXPECT_EQ(FILE_PATH_LITERAL("folders"), contents.back().name);
}

Powered by Google App Engine
This is Rietveld 408576698