Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac_unittest.mm

Issue 1432403003: Do not call stat() when reading directories via File API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed FSP tests. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import <Foundation/Foundation.h> 5 #import <Foundation/Foundation.h>
6 #import <ImageCaptureCore/ImageCaptureCore.h> 6 #import <ImageCaptureCore/ImageCaptureCore.h>
7 7
8 #include "base/files/file.h" 8 #include "base/files/file.h"
9 #include "base/files/file_util.h" 9 #include "base/files/file_util.h"
10 #include "base/files/scoped_temp_dir.h" 10 #include "base/files/scoped_temp_dir.h"
(...skipping 382 matching lines...) Expand 10 before | Expand all | Expand 10 after
393 delegate_->ItemAdded("name2", info1); 393 delegate_->ItemAdded("name2", info1);
394 delegate_->NoMoreItems(); 394 delegate_->NoMoreItems();
395 395
396 EXPECT_EQ(base::File::FILE_OK, 396 EXPECT_EQ(base::File::FILE_OK,
397 GetFileInfo(base::FilePath("/ic:id/name2"), &info)); 397 GetFileInfo(base::FilePath("/ic:id/name2"), &info));
398 EXPECT_EQ(info1.size, info.size); 398 EXPECT_EQ(info1.size, info.size);
399 399
400 EXPECT_EQ(base::File::FILE_OK, ReadDir(base::FilePath(kDevicePath))); 400 EXPECT_EQ(base::File::FILE_OK, ReadDir(base::FilePath(kDevicePath)));
401 401
402 ASSERT_EQ(2U, file_list_.size()); 402 ASSERT_EQ(2U, file_list_.size());
403 EXPECT_EQ(time1, file_list_[0].last_modified_time);
404 EXPECT_FALSE(file_list_[0].is_directory); 403 EXPECT_FALSE(file_list_[0].is_directory);
405 EXPECT_EQ("name1", file_list_[0].name); 404 EXPECT_EQ("name1", file_list_[0].name);
406 405
407 EXPECT_EQ(time1, file_list_[1].last_modified_time);
408 EXPECT_FALSE(file_list_[1].is_directory); 406 EXPECT_FALSE(file_list_[1].is_directory);
409 EXPECT_EQ("name2", file_list_[1].name); 407 EXPECT_EQ("name2", file_list_[1].name);
410 } 408 }
411 409
412 TEST_F(MTPDeviceDelegateImplMacTest, TestDirectoriesAndSorting) { 410 TEST_F(MTPDeviceDelegateImplMacTest, TestDirectoriesAndSorting) {
413 base::Time time1 = base::Time::Now(); 411 base::Time time1 = base::Time::Now();
414 base::File::Info info1; 412 base::File::Info info1;
415 info1.size = 1; 413 info1.size = 1;
416 info1.is_directory = false; 414 info1.is_directory = false;
417 info1.is_symbolic_link = false; 415 info1.is_symbolic_link = false;
418 info1.last_modified = time1; 416 info1.last_modified = time1;
419 info1.last_accessed = time1; 417 info1.last_accessed = time1;
420 info1.creation_time = time1; 418 info1.creation_time = time1;
421 delegate_->ItemAdded("name2", info1); 419 delegate_->ItemAdded("name2", info1);
422 420
423 info1.is_directory = true; 421 info1.is_directory = true;
424 delegate_->ItemAdded("dir2", info1); 422 delegate_->ItemAdded("dir2", info1);
425 delegate_->ItemAdded("dir1", info1); 423 delegate_->ItemAdded("dir1", info1);
426 424
427 info1.is_directory = false; 425 info1.is_directory = false;
428 delegate_->ItemAdded("name1", info1); 426 delegate_->ItemAdded("name1", info1);
429 delegate_->NoMoreItems(); 427 delegate_->NoMoreItems();
430 428
431 EXPECT_EQ(base::File::FILE_OK, ReadDir(base::FilePath(kDevicePath))); 429 EXPECT_EQ(base::File::FILE_OK, ReadDir(base::FilePath(kDevicePath)));
432 430
433 ASSERT_EQ(4U, file_list_.size()); 431 ASSERT_EQ(4U, file_list_.size());
434 EXPECT_EQ("dir1", file_list_[0].name); 432 EXPECT_EQ("dir1", file_list_[0].name);
435 EXPECT_EQ("dir2", file_list_[1].name); 433 EXPECT_EQ("dir2", file_list_[1].name);
436 EXPECT_EQ(time1, file_list_[2].last_modified_time);
437 EXPECT_FALSE(file_list_[2].is_directory); 434 EXPECT_FALSE(file_list_[2].is_directory);
438 EXPECT_EQ("name1", file_list_[2].name); 435 EXPECT_EQ("name1", file_list_[2].name);
439 436
440 EXPECT_EQ(time1, file_list_[3].last_modified_time);
441 EXPECT_FALSE(file_list_[3].is_directory); 437 EXPECT_FALSE(file_list_[3].is_directory);
442 EXPECT_EQ("name2", file_list_[3].name); 438 EXPECT_EQ("name2", file_list_[3].name);
443 } 439 }
444 440
445 TEST_F(MTPDeviceDelegateImplMacTest, SubDirectories) { 441 TEST_F(MTPDeviceDelegateImplMacTest, SubDirectories) {
446 base::Time time1 = base::Time::Now(); 442 base::Time time1 = base::Time::Now();
447 base::File::Info info1; 443 base::File::Info info1;
448 info1.size = 0; 444 info1.size = 0;
449 info1.is_directory = true; 445 info1.is_directory = true;
450 info1.is_symbolic_link = false; 446 info1.is_symbolic_link = false;
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
547 temp_dir_.path().Append("target"))); 543 temp_dir_.path().Append("target")));
548 544
549 EXPECT_EQ(base::File::FILE_OK, 545 EXPECT_EQ(base::File::FILE_OK,
550 DownloadFile(base::FilePath("/ic:id/filename"), 546 DownloadFile(base::FilePath("/ic:id/filename"),
551 temp_dir_.path().Append("target"))); 547 temp_dir_.path().Append("target")));
552 std::string contents; 548 std::string contents;
553 EXPECT_TRUE(base::ReadFileToString(temp_dir_.path().Append("target"), 549 EXPECT_TRUE(base::ReadFileToString(temp_dir_.path().Append("target"),
554 &contents)); 550 &contents));
555 EXPECT_EQ(kTestFileContents, contents); 551 EXPECT_EQ(kTestFileContents, contents);
556 } 552 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698