Do not call stat() when reading directories via File API.

chrome/browser/chromeos/file_system_provider/operations/get_metadata_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/file_system_provider/operations/get_metadata.h"
 
 #include <string>
 
 #include "base/files/file.h"
 #include "base/files/file_path.h"
@@ skipping 74 matching lines @@
   const ScopedVector<Event>& events() const { return events_; }
 
  private:
   ScopedVector<Event> events_;
 
   DISALLOW_COPY_AND_ASSIGN(CallbackLogger);
 };
 
 }  // namespace
 
+using ModificationTime =
+    extensions::api::file_system_provider::EntryMetadata::ModificationTime;
+
 class FileSystemProviderOperationsGetMetadataTest : public testing::Test {
  protected:
   FileSystemProviderOperationsGetMetadataTest() {}
   ~FileSystemProviderOperationsGetMetadataTest() override {}
 
   void SetUp() override {
     file_system_info_ = ProvidedFileSystemInfo(
         kExtensionId, MountOptions(kFileSystemId, "" /* display_name */),
         base::FilePath(), false /* configurable */, true /* watchable */,
         extensions::SOURCE_FILE);
@@ skipping 15 matching lines @@
 
 TEST_F(FileSystemProviderOperationsGetMetadataTest, ValidateIDLEntryMetadata) {
   using extensions::api::file_system_provider::EntryMetadata;
   const std::string kValidFileName = "hello-world";
   const std::string kValidThumbnailUrl = "data:something";
 
   // Correct metadata for non-root.
   {
     EntryMetadata metadata;
     metadata.name = kValidFileName;
-    metadata.modification_time.additional_properties.SetString(
+    metadata.modification_time.reset(new ModificationTime());
+    metadata.modification_time->additional_properties.SetString(
         "value", "invalid-date-time");  // Invalid modification time is OK.
     metadata.thumbnail.reset(new std::string(kValidThumbnailUrl));
     EXPECT_TRUE(ValidateIDLEntryMetadata(metadata, false /* root_path */));
   }
 
   // Correct metadata for non-root (without thumbnail).
   {
     EntryMetadata metadata;
     metadata.name = kValidFileName;
-    metadata.modification_time.additional_properties.SetString(
+    metadata.modification_time.reset(new ModificationTime());
+    metadata.modification_time->additional_properties.SetString(
         "value", "invalid-date-time");  // Invalid modification time is OK.
     EXPECT_TRUE(ValidateIDLEntryMetadata(metadata, false /* root_path */));
   }
 
   // Correct metadata for root.
   {
     EntryMetadata metadata;
     metadata.name = "";
-    metadata.modification_time.additional_properties.SetString(
+    metadata.modification_time.reset(new ModificationTime());
+    metadata.modification_time->additional_properties.SetString(
         "value", "invalid-date-time");  // Invalid modification time is OK.
     EXPECT_TRUE(ValidateIDLEntryMetadata(metadata, true /* root_path */));
   }
 
   // Invalid characters in the name.
   {
     EntryMetadata metadata;
     metadata.name = "hello/world";
-    metadata.modification_time.additional_properties.SetString(
+    metadata.modification_time.reset(new ModificationTime());
+    metadata.modification_time->additional_properties.SetString(
         "value", "invalid-date-time");  // Invalid modification time is OK.
     metadata.thumbnail.reset(new std::string(kValidThumbnailUrl));
     EXPECT_FALSE(ValidateIDLEntryMetadata(metadata, false /* root_path */));
   }
 
   // Empty name for non-root.
   {
     EntryMetadata metadata;
     metadata.name = "";
-    metadata.modification_time.additional_properties.SetString(
+    metadata.modification_time.reset(new ModificationTime());
+    metadata.modification_time->additional_properties.SetString(
         "value", "invalid-date-time");  // Invalid modification time is OK.
     metadata.thumbnail.reset(new std::string(kValidThumbnailUrl));
     EXPECT_FALSE(ValidateIDLEntryMetadata(metadata, false /* root_path */));
   }
 
-  // Missing date time.
+  // Missing last modification time is allowed.
   {
     EntryMetadata metadata;
     metadata.name = kValidFileName;
     metadata.thumbnail.reset(new std::string(kValidThumbnailUrl));
-    EXPECT_FALSE(ValidateIDLEntryMetadata(metadata, false /* root_path */));
+    EXPECT_TRUE(ValidateIDLEntryMetadata(metadata, false /* root_path */));
   }
 
   // Invalid thumbnail.
   {
     EntryMetadata metadata;
     metadata.name = kValidFileName;
-    metadata.modification_time.additional_properties.SetString(
+    metadata.modification_time.reset(new ModificationTime());
+    metadata.modification_time->additional_properties.SetString(
         "value", "invalid-date-time");  // Invalid modification time is OK.
     metadata.thumbnail.reset(new std::string("http://invalid-scheme"));
     EXPECT_FALSE(ValidateIDLEntryMetadata(metadata, false /* root_path */));
   }
 }
 
 TEST_F(FileSystemProviderOperationsGetMetadataTest, Execute) {
   using extensions::api::file_system_provider::GetMetadataRequestedOptions;
 
   util::LoggingDispatchEventImpl dispatcher(true /* dispatch_reply */);
@@ skipping 170 matching lines @@
                        base::File::FILE_ERROR_TOO_MANY_OPENED);
 
   ASSERT_EQ(1u, callback_logger.events().size());
   CallbackLogger::Event* event = callback_logger.events()[0];
   EXPECT_EQ(base::File::FILE_ERROR_TOO_MANY_OPENED, event->result());
 }
 
 }  // namespace operations
 }  // namespace file_system_provider
 }  // namespace chromeos