Add support for disabling CSS Properties at runtime

bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp

 /*
  * Copyright (C) 2007-2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 19 matching lines @@
 
 #include "config.h"
 #include "V8CSSStyleDeclaration.h"
 
 #include "CSSParser.h"
 #include "CSSPropertyNames.h"
 #include "CSSStyleDeclaration.h"
 #include "CSSValue.h"
 #include "CSSPrimitiveValue.h"
 #include "EventTarget.h"
+#include "HashTools.h"
+#include "RuntimeCSSEnabled.h"
 
 #include "V8Binding.h"
 
 #include <wtf/text/StringBuilder.h>
 #include <wtf/text/StringConcatenate.h>
 #include <wtf/ASCIICType.h>
 #include <wtf/PassRefPtr.h>
 #include <wtf/RefPtr.h>
 #include <wtf/StdLibExtras.h>
 #include <wtf/Vector.h>
@@ skipping 84 matching lines @@
         for (; i < length; ++i) {
             UChar c = propertyName[i];
             if (!isASCIIUpper(c))
                 builder.append(c);
             else
                 builder.append(makeString('-', toASCIILower(c)));
         }
 
         String propName = builder.toString();
         CSSPropertyID propertyID = cssPropertyID(propName);
-        if (propertyID) {
+        if (propertyID && RuntimeCSSEnabled::isCSSPropertyEnabled(propertyID)) {
             propInfo = new CSSPropertyInfo();
             propInfo->hadPixelOrPosPrefix = hadPixelOrPosPrefix;
             propInfo->propID = propertyID;
             map.add(propertyName, propInfo);
         }
     }
     return propInfo;
 }
 
+static bool isCSSValueEnabled(String& value)
+{
+    const struct Value* propertyValue = findValue(
+        reinterpret_cast<const char*>(value.characters8()),
+        value.length());
+
+    if (!propertyValue)
+        return true;
+    return RuntimeCSSEnabled::isCSSValueEnabled(
+        static_cast<CSSValueID>(propertyValue->id));   
+}
+
+static bool isValueOfPropertyEnabled(CSSStyleDeclaration* imp, v8::Local<v8::String> propertyName)
+{
+    if (!imp)
+        return true;
+
+    CSSPropertyInfo* propInfo = cssPropertyInfo(propertyName);
+    if (!propInfo || propInfo->propID == CSSPropertyInvalid)

[eseidel, 2013/04/23 01:36:36]

When is CSSPropertyInvalid ever possible in propInfo?  Assuming
CSSPropertyInvalid == 0, then this should never be possible?

+        return true;
+
+    String propertyValueName = imp->getPropertyValueInternal(propInfo->propID);
+    if (propertyValueName.isEmpty())
+        return true;
+    return isCSSValueEnabled(propertyValueName);
+}
+
 v8::Handle<v8::Array> V8CSSStyleDeclaration::namedPropertyEnumerator(const v8::AccessorInfo& info)
 {
     typedef Vector<String, numCSSProperties - 1> PreAllocatedPropertyVector;
     DEFINE_STATIC_LOCAL(PreAllocatedPropertyVector, propertyNames, ());
     static unsigned propertyNamesLength = 0;
 
     if (propertyNames.isEmpty()) {
         for (int id = firstCSSProperty; id < firstCSSProperty + numCSSProperties; ++id)
-            propertyNames.append(getJSPropertyName(static_cast<CSSPropertyID>(id)));
+            if (RuntimeCSSEnabled::isCSSPropertyEnabled(static_cast<CSSPropertyID>(id)))
+                propertyNames.append(getJSPropertyName(static_cast<CSSPropertyID>(id)));
         sort(propertyNames.begin(), propertyNames.end(), codePointCompareLessThan);
         propertyNamesLength = propertyNames.size();
     }
 
     v8::Handle<v8::Array> properties = v8::Array::New(propertyNamesLength);
     for (unsigned i = 0; i < propertyNamesLength; ++i) {
         String key = propertyNames.at(i);
         ASSERT(!key.isNull());
         properties->Set(v8Integer(i, info.GetIsolate()), v8String(key, info.GetIsolate()));
     }
@@ skipping 16 matching lines @@
         return v8Undefined();
 
     // Search the style declaration.
     CSSPropertyInfo* propInfo = cssPropertyInfo(name);
 
     // Do not handle non-property names.
     if (!propInfo)
         return v8Undefined();
 
     CSSStyleDeclaration* imp = V8CSSStyleDeclaration::toNative(info.Holder());
+    if (!isValueOfPropertyEnabled(imp, name))
+        return v8Undefined();
+
     RefPtr<CSSValue> cssValue = imp->getPropertyCSSValueInternal(static_cast<CSSPropertyID>(propInfo->propID));
     if (cssValue) {
         if (propInfo->hadPixelOrPosPrefix &&
             cssValue->isPrimitiveValue()) {
             return v8::Number::New(static_cast<CSSPrimitiveValue*>(
                 cssValue.get())->getFloatValue(CSSPrimitiveValue::CSS_PX));
         }
         return v8StringOrNull(cssValue->cssText(), info.GetIsolate());
     }
 
     String result = imp->getPropertyValueInternal(static_cast<CSSPropertyID>(propInfo->propID));
     if (result.isNull())
         result = "";  // convert null to empty string.
 
     return v8String(result, info.GetIsolate());
 }
 
 v8::Handle<v8::Value> V8CSSStyleDeclaration::namedPropertySetter(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::AccessorInfo& info)
 {
+    String wsValue = toWebCoreString(value);
+    if (!isCSSValueEnabled(wsValue))

[eseidel, 2013/04/23 01:32:00]

I don't believe this part is correct or necessary.  I think this would make it
detectable that a property existed and was disabled. :)  We should disable these
in the parser and not at this choke point.

+        return v8Undefined();
+
     CSSStyleDeclaration* imp = V8CSSStyleDeclaration::toNative(info.Holder());
     CSSPropertyInfo* propInfo = cssPropertyInfo(name);
     if (!propInfo)
         return v8Undefined();
 
     String propertyValue = toWebCoreStringWithNullCheck(value);
     if (propInfo->hadPixelOrPosPrefix)
         propertyValue.append("px");
 
     ExceptionCode ec = 0;
     imp->setPropertyInternal(static_cast<CSSPropertyID>(propInfo->propID), propertyValue, false, ec);
 
     if (ec)
         setDOMException(ec, info.GetIsolate());
 
     return value;
 }
 
 } // namespace WebCore