Add support for disabling CSS Properties at runtime

Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp

 /*
  * Copyright (C) 2007-2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 19 matching lines @@
 
 #include "config.h"
 #include "V8CSSStyleDeclaration.h"
 
 #include "CSSPropertyNames.h"
 #include "core/css/CSSParser.h"
 #include "core/css/CSSPrimitiveValue.h"
 #include "core/css/CSSStyleDeclaration.h"
 #include "core/css/CSSValue.h"
 #include "core/dom/EventTarget.h"
+#include "core/page/RuntimeCSSEnabled.h"
 
 #include "bindings/v8/V8Binding.h"
 
 #include "wtf/ASCIICType.h"
 #include "wtf/PassRefPtr.h"
 #include "wtf/RefPtr.h"
 #include "wtf/StdLibExtras.h"
 #include "wtf/Vector.h"
 #include "wtf/text/StringBuilder.h"
 #include "wtf/text/StringConcatenate.h"
@@ skipping 42 matching lines @@
 // Javascript and the actual name of the property are not the same, so
 // we have to do the following translation.  The translation turns upper
 // case characters into lower case characters and inserts dashes to
 // separate words.
 //
 // Example: 'backgroundPositionY' -> 'background-position-y'
 //
 // Also, certain prefixes such as 'pos', 'css-' and 'pixel-' are stripped
 // and the hadPixelOrPosPrefix out parameter is used to indicate whether or
 // not the property name was prefixed with 'pos-' or 'pixel-'.
-static CSSPropertyInfo* cssPropertyInfo(v8::Handle<v8::String>v8PropertyName)
+static CSSPropertyInfo* cssPropertyInfo(v8::Handle<v8::String> v8PropertyName)
 {
     String propertyName = toWebCoreString(v8PropertyName);
     typedef HashMap<String, CSSPropertyInfo*> CSSPropertyInfoMap;
     DEFINE_STATIC_LOCAL(CSSPropertyInfoMap, map, ());
     CSSPropertyInfo* propInfo = map.get(propertyName);
     if (!propInfo) {
         unsigned length = propertyName.length();
         bool hadPixelOrPosPrefix = false;
         if (!length)
             return 0;
@@ skipping 21 matching lines @@
         for (; i < length; ++i) {
             UChar c = propertyName[i];
             if (!isASCIIUpper(c))
                 builder.append(c);
             else
                 builder.append(makeString('-', toASCIILower(c)));
         }
 
         String propName = builder.toString();
         CSSPropertyID propertyID = cssPropertyID(propName);
-        if (propertyID) {
+        if (propertyID && RuntimeCSSEnabled::isCSSPropertyEnabled(propertyID)) {
             propInfo = new CSSPropertyInfo();
             propInfo->hadPixelOrPosPrefix = hadPixelOrPosPrefix;
             propInfo->propID = propertyID;
             map.add(propertyName, propInfo);
         }
     }
     return propInfo;
 }
 
 v8::Handle<v8::Array> V8CSSStyleDeclaration::namedPropertyEnumerator(const v8::AccessorInfo& info)
 {
     typedef Vector<String, numCSSProperties - 1> PreAllocatedPropertyVector;
     DEFINE_STATIC_LOCAL(PreAllocatedPropertyVector, propertyNames, ());
     static unsigned propertyNamesLength = 0;
 
     if (propertyNames.isEmpty()) {
-        for (int id = firstCSSProperty; id < firstCSSProperty + numCSSProperties; ++id)
-            propertyNames.append(getJSPropertyName(static_cast<CSSPropertyID>(id)));
+        for (int id = firstCSSProperty; id < firstCSSProperty + numCSSProperties; ++id) {

[mitica, 2013/04/24 06:24:25]

It would probably be better to use lastCSSProperty instead of
firstCSSProperty+numCSSProperties

+            CSSPropertyID propertyId = static_cast<CSSPropertyID>(id);
+            if (RuntimeCSSEnabled::isCSSPropertyEnabled(propertyId))
+                propertyNames.append(getJSPropertyName(propertyId));
+        }
         sort(propertyNames.begin(), propertyNames.end(), codePointCompareLessThan);
         propertyNamesLength = propertyNames.size();
     }
 
     v8::Handle<v8::Array> properties = v8::Array::New(propertyNamesLength);
     for (unsigned i = 0; i < propertyNamesLength; ++i) {
         String key = propertyNames.at(i);
         ASSERT(!key.isNull());
         properties->Set(v8Integer(i, info.GetIsolate()), v8String(key, info.GetIsolate()));
     }
 
     return properties;
 }
 
 v8::Handle<v8::Integer> V8CSSStyleDeclaration::namedPropertyQuery(v8::Local<v8::String> v8Name, const v8::AccessorInfo& info)
 {
+    // NOTE: cssPropertyInfo lookups incur several mallocs.
+    // Successful lookups have the same cost the first time, but are cached.
     if (cssPropertyInfo(v8Name))
         return v8Integer(0, info.GetIsolate());
 
     return v8::Handle<v8::Integer>();
 }
 
 v8::Handle<v8::Value> V8CSSStyleDeclaration::namedPropertyGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
 {
     // First look for API defined attributes on the style declaration object.
     if (info.Holder()->HasRealNamedCallbackProperty(name))
@@ skipping 38 matching lines @@
     ExceptionCode ec = 0;
     imp->setPropertyInternal(static_cast<CSSPropertyID>(propInfo->propID), propertyValue, false, ec);
 
     if (ec)
         setDOMException(ec, info.GetIsolate());
 
     return value;
 }
 
 } // namespace WebCore