Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: ui/file_manager/audio_player/js/audio_player.js

Issue 1432393003: Revert of AudioPlayer: Update volume controls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/audio_player/js/audio_player.js
diff --git a/ui/file_manager/audio_player/js/audio_player.js b/ui/file_manager/audio_player/js/audio_player.js
index fea6cd4b780226edc7e5f8c227b7265ce2b91d09..eb9459127c86751112d17e8f511045579e0c4aaa 100644
--- a/ui/file_manager/audio_player/js/audio_player.js
+++ b/ui/file_manager/audio_player/js/audio_player.js
@@ -24,13 +24,9 @@
Object.observe(this.model_, function(changes) {
for (var i = 0; i < changes.length; i++) {
var change = changes[i];
- if (change.name === 'expanded' &&
- (change.type === 'add' || change.type === 'update')) {
+ if (change.name == 'expanded' &&
+ (change.type == 'add' || change.type == 'update')) {
this.onModelExpandedChanged(change.oldValue, change.object.expanded);
- break;
- } else if (change.name === 'volumeSliderShown' &&
- (change.type === 'add' || change.type === 'update')) {
- this.onModelVolumeSliderShownChanged();
break;
}
}
@@ -288,11 +284,11 @@
*/
AudioPlayer.prototype.onResize_ = function(event) {
if (!this.isExpanded_ &&
- window.innerHeight >= this.getExpandedModeMinHeight_()) {
+ window.innerHeight >= AudioPlayer.EXPANDED_MODE_MIN_HEIGHT) {
this.isExpanded_ = true;
this.player_.expanded = true;
} else if (this.isExpanded_ &&
- window.innerHeight < this.getExpandedModeMinHeight_()) {
+ window.innerHeight < AudioPlayer.EXPANDED_MODE_MIN_HEIGHT) {
this.isExpanded_ = false;
this.player_.expanded = false;
}
@@ -339,25 +335,11 @@
AudioPlayer.TRACK_HEIGHT = 48;
/**
- * Volume slider's height in pixels.
+ * Controls bar height in pixels.
* @type {number}
* @const
*/
-AudioPlayer.VOLUME_SLIDER_HEIGHT = 48;
-
-/**
- * Height of the control which has buttons such as play, next, shffule, etc...
- * @type {number}
- * @const
- */
-AudioPlayer.BUTTONS_CONTROL_HEIGHT = 48;
-
-/**
- * Height of the control which has progress slider, time, and duration.
- * @type {number}
- * @const
- */
-AudioPlayer.TIME_CONTROL_HEIGHT = 48;
+AudioPlayer.CONTROLS_HEIGHT = 96;
/**
* Default number of items in the expanded mode.
@@ -365,6 +347,14 @@
* @const
*/
AudioPlayer.DEFAULT_EXPANDED_ITEMS = 5;
+
+/**
+ * Minimum size of the window in the expanded mode in pixels.
+ * @type {number}
+ * @const
+ */
+AudioPlayer.EXPANDED_MODE_MIN_HEIGHT = AudioPlayer.CONTROLS_HEIGHT +
+ AudioPlayer.TRACK_HEIGHT * 2;
/**
* Invoked when the 'expanded' property in the model is changed.
@@ -390,13 +380,6 @@
};
/**
- * Invoked when the 'volumeSliderShown' property in the model is changed.
- */
-AudioPlayer.prototype.onModelVolumeSliderShownChanged = function() {
- this.syncHeight_();
-};
-
-/**
* @private
*/
AudioPlayer.prototype.syncHeight_ = function() {
@@ -405,46 +388,21 @@
if (this.player_.expanded) {
// Expanded.
if (!this.lastExpandedHeight_ ||
- this.lastExpandedHeight_ < this.getExpandedModeMinHeight_()) {
+ this.lastExpandedHeight_ < AudioPlayer.EXPANDED_MODE_MIN_HEIGHT) {
var expandedListHeight =
Math.min(this.entries_.length, AudioPlayer.DEFAULT_EXPANDED_ITEMS) *
AudioPlayer.TRACK_HEIGHT;
- targetHeight = this.getControlsHeight_() + expandedListHeight;
+ targetHeight = AudioPlayer.CONTROLS_HEIGHT + expandedListHeight;
this.lastExpandedHeight_ = targetHeight;
} else {
targetHeight = this.lastExpandedHeight_;
}
} else {
// Not expanded.
- targetHeight = this.getControlsHeight_() + AudioPlayer.TRACK_HEIGHT;
+ targetHeight = AudioPlayer.CONTROLS_HEIGHT + AudioPlayer.TRACK_HEIGHT;
}
window.resizeTo(window.innerWidth, targetHeight + AudioPlayer.HEADER_HEIGHT);
-};
-
-/**
- * Calculates the height of control panel.
- * @return {number} Current height of control panel in pixels.
- * @private
- */
-AudioPlayer.prototype.getControlsHeight_ = function() {
- var height = AudioPlayer.BUTTONS_CONTROL_HEIGHT +
- AudioPlayer.TIME_CONTROL_HEIGHT;
- if (this.player_.volumeSliderShown)
- height += AudioPlayer.VOLUME_SLIDER_HEIGHT;
-
- return height;
-};
-
-/**
- * Calculates the minium height of the app to show the playlist in expanded
- * mode.
- * @return {number} The minimum height of audio app window in which we can show
- * the playlist in expanded mode.
- * @private
- */
-AudioPlayer.prototype.getExpandedModeMinHeight_ = function() {
- return this.getControlsHeight_() + AudioPlayer.TRACK_HEIGHT * 2;
};
/**
« no previous file with comments | « ui/file_manager/audio_player/elements/volume_controller.js ('k') | ui/file_manager/audio_player/js/audio_player_model.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698