Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1432393003: Revert of AudioPlayer: Update volume controls. (Closed)

Created:
5 years, 1 month ago by fukino
Modified:
5 years, 1 month ago
Reviewers:
yawano
CC:
chromium-reviews, vitalyp+closure_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of AudioPlayer: Update volume controls. (patchset #4 id:60001 of https://codereview.chromium.org/1425033006/ ) Reason for revert: We decided to punt redesign of audio player to M49. Original issue's description: > AudioPlayer: Update volume controls. > > This CL includes: > - Custom volume slider is replaced with paper-slider, which is dynamically shown on the top of control panel when volume button is activated. > > BUG=488229 > > Committed: https://crrev.com/8847bc03c848c4f5dab165b9cb796a79ec69ef72 > Cr-Commit-Position: refs/heads/master@{#357069} TBR=yawano@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=488229 Committed: https://crrev.com/7ca3f86984f7527a62fcf76ed454f3afd99fe6e3 Cr-Commit-Position: refs/heads/master@{#359284}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+324 lines, -101 lines) Patch
M ui/file_manager/audio_player/elements/audio_player.html View 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/audio_player/elements/audio_player.js View 3 chunks +0 lines, -17 lines 0 comments Download
M ui/file_manager/audio_player/elements/compiled_resources.gyp View 1 chunk +10 lines, -0 lines 0 comments Download
M ui/file_manager/audio_player/elements/control_panel.css View 3 chunks +17 lines, -16 lines 0 comments Download
M ui/file_manager/audio_player/elements/control_panel.html View 4 chunks +13 lines, -5 lines 0 comments Download
M ui/file_manager/audio_player/elements/control_panel.js View 4 chunks +65 lines, -2 lines 0 comments Download
A ui/file_manager/audio_player/elements/volume_controller.css View 1 chunk +52 lines, -0 lines 0 comments Download
A ui/file_manager/audio_player/elements/volume_controller.html View 1 chunk +23 lines, -0 lines 0 comments Download
A ui/file_manager/audio_player/elements/volume_controller.js View 1 chunk +124 lines, -0 lines 0 comments Download
M ui/file_manager/audio_player/js/audio_player.js View 6 chunks +17 lines, -59 lines 0 comments Download
M ui/file_manager/audio_player/js/audio_player_model.js View 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/file_manager_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
fukino
Created Revert of AudioPlayer: Update volume controls.
5 years, 1 month ago (2015-11-12 08:23:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1432393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1432393003/1
5 years, 1 month ago (2015-11-12 08:24:14 UTC) #2
commit-bot: I haz the power
Failed to apply patch for ui/file_manager/audio_player/elements/compiled_resources.gyp: While running git apply --index -3 -p1; error: ui/file_manager/audio_player/elements/compiled_resources.gyp: ...
5 years, 1 month ago (2015-11-12 08:24:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1432393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1432393003/1
5 years, 1 month ago (2015-11-12 08:28:57 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 08:29:44 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:05:54 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ca3f86984f7527a62fcf76ed454f3afd99fe6e3
Cr-Commit-Position: refs/heads/master@{#359284}

Powered by Google App Engine
This is Rietveld 408576698