Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: pkg/analyzer/lib/src/task/driver.dart

Issue 1432293002: Remove task inputs performance statistics. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/status/get_handler.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/task/driver.dart
diff --git a/pkg/analyzer/lib/src/task/driver.dart b/pkg/analyzer/lib/src/task/driver.dart
index c6abda8d4c3cc44ef515df66e5964cf9e379dd8d..fc8d46a10a3e0e7ca81d63261313633ea9b1099e 100644
--- a/pkg/analyzer/lib/src/task/driver.dart
+++ b/pkg/analyzer/lib/src/task/driver.dart
@@ -530,21 +530,6 @@ class StronglyConnectedComponent<Node> {
*/
class WorkItem {
/**
- * A table mapping the names of analysis tasks to the number of times each
- * kind of task has been performed.
- */
- static final Map<TaskDescriptor, int> countMap =
- new HashMap<TaskDescriptor, int>();
-
- /**
- * A table mapping the names of analysis tasks to stopwatches used to compute
- * how much time was spent between creating an item and creating (for
- * performing) of each kind of task
- */
- static final Map<TaskDescriptor, Stopwatch> stopwatchMap =
- new HashMap<TaskDescriptor, Stopwatch>();
-
- /**
* The context in which the task will be performed.
*/
final InternalAnalysisContext context;
@@ -565,11 +550,6 @@ class WorkItem {
final ResultDescriptor spawningResult;
/**
- * The current inputs computing stopwatch.
- */
- Stopwatch stopwatch;
-
- /**
* An iterator used to iterate over the descriptors of the inputs to the task,
* or `null` if all of the inputs have been collected and the task can be
* created.
@@ -619,19 +599,6 @@ class WorkItem {
builder = null;
}
inputs = new HashMap<String, dynamic>();
- // Update performance counters.
- {
- stopwatch = stopwatchMap[descriptor];
- if (stopwatch == null) {
- stopwatch = new Stopwatch();
- stopwatchMap[descriptor] = stopwatch;
- }
- stopwatch.start();
- }
- {
- int count = countMap[descriptor];
- countMap[descriptor] = count == null ? 1 : count + 1;
- }
}
@override
@@ -651,7 +618,6 @@ class WorkItem {
* Build the task represented by this work item.
*/
AnalysisTask buildTask() {
- stopwatch.stop();
if (builder != null) {
throw new StateError("some inputs have not been computed");
}
« no previous file with comments | « pkg/analysis_server/lib/src/status/get_handler.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698