Issue 143223004: Generalize internalization of substrings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 143223004: Generalize internalization of substrings. (Closed)

Created:
6 years, 11 months ago by ulan

Modified:
6 years, 10 months ago

Reviewers:
dcarney, Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Generalize internalization of substrings. Make a template version of SubStringKey, which allows internalization of substrings of sequential and external strings. R=dcarney@chromium.org, svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18910

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -21 lines)			Patch
M	src/factory.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/factory.cc	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	src/objects.cc	View		1 chunk	+48 lines, -4 lines	0 comments	Download
M	src/objects-inl.h	View	1	2 chunks	+22 lines, -13 lines	0 comments	Download

Total messages: 4 (0 generated)

ulan

6 years, 10 months ago (2014-01-29 14:31:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r18910 (presubmit successful).