Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1432223002: [turbofan] Don't try to inline our builtins. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Don't try to inline our builtins. R=mstarzinger@chromium.org BUG=v8:4493 LOG=n Committed: https://crrev.com/095e6a4f84f6da32aef81ee105eab75ee024d338 Cr-Commit-Position: refs/heads/master@{#31944}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/compiler/js-inlining-heuristic.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-11 13:40:59 UTC) #1
Michael Starzinger
LGTM. Disable all the inlinings!
5 years, 1 month ago (2015-11-11 13:42:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1432223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1432223002/1
5 years, 1 month ago (2015-11-11 13:53:29 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-11 14:27:50 UTC) #5
adamk
Can I ask why? Last time this came up I was under the impression that ...
5 years, 1 month ago (2015-11-11 18:35:55 UTC) #7
Benedikt Meurer (Google)
On 2015/11/11 18:35:55, adamk wrote: > Can I ask why? Last time this came up ...
5 years, 1 month ago (2015-11-12 02:42:35 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:20:06 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/095e6a4f84f6da32aef81ee105eab75ee024d338
Cr-Commit-Position: refs/heads/master@{#31944}

Powered by Google App Engine
This is Rietveld 408576698