Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 1432203002: Revert "Add data-URI support class to dart:core (next to Uri)." (Closed)

Created:
5 years, 1 month ago by Bill Hesse
Modified:
5 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Add data-URI support class to dart:core (next to Uri)." This reverts commit bbc66c2c41e61d82d6b85fdd16e2b0f1204c2a33. BUG= R=ricow@google.com Committed: https://github.com/dart-lang/sdk/commit/df5ef1b1368ed8189e415d2a3061c6f02c4f914e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -1003 lines) Patch
M CHANGELOG.md View 1 chunk +0 lines, -7 lines 0 comments Download
M runtime/bin/builtin.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/convert/base64.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M sdk/lib/core/core.dart View 1 chunk +1 line, -4 lines 0 comments Download
M sdk/lib/core/uri.dart View 14 chunks +48 lines, -732 lines 0 comments Download
D tests/corelib/data_uri_test.dart View 1 chunk +0 lines, -252 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bill Hesse
5 years, 1 month ago (2015-11-11 10:40:26 UTC) #2
ricow1
lgtm
5 years, 1 month ago (2015-11-11 10:41:44 UTC) #4
Bill Hesse
5 years, 1 month ago (2015-11-11 10:42:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
df5ef1b1368ed8189e415d2a3061c6f02c4f914e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698