chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc - Issue 14322023: Don't request missing favicon on every page request.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc

Issue 14322023: Don't request missing favicon on every page request. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: sync up to r199996 Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc

diff --git a/chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc b/chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc

index 0c9e14cb92dd0b30961137b8fd339cc2c370af4f..051e468e8816572802ec1b31b48114db8668c402 100644

--- a/chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc

+++ b/chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc

@@ -47,6 +47,7 @@ class FaviconBitmapHandler : public content::WebContentsObserver {

private:

void DidDownloadFavicon(

int id,

+ int http_status_code,

const GURL& image_url,

int requested_size,

const std::vector<SkBitmap>& bitmaps);

@@ -121,6 +122,7 @@ bool FaviconBitmapHandler::HasPendingDownloads() const {

void FaviconBitmapHandler::DidDownloadFavicon(

int id,

+ int http_status_code,

const GURL& image_url,

int requested_size,

const std::vector<SkBitmap>& bitmaps) {