chrome/browser/ui/web_applications/web_app_ui.cc - Issue 14322023: Don't request missing favicon on every page request.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/web_applications/web_app_ui.cc

Issue 14322023: Don't request missing favicon on every page request. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added TEST_F(FaviconHandlerTest, UnableToDownloadFavicon) Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/web_applications/web_app_ui.cc

diff --git a/chrome/browser/ui/web_applications/web_app_ui.cc b/chrome/browser/ui/web_applications/web_app_ui.cc

index 4788e337de7f42f939d58e764e6a0e0856f0aafe..fd4a9daa38f0863153e15d897b99c4ba07b8c4a7 100644

--- a/chrome/browser/ui/web_applications/web_app_ui.cc

+++ b/chrome/browser/ui/web_applications/web_app_ui.cc

@@ -89,6 +89,7 @@ class UpdateShortcutWorker : public content::NotificationObserver {

// Favicon download callback.

void DidDownloadFavicon(

int id,

+ int http_status_code,

const GURL& image_url,

int requested_size,

const std::vector<SkBitmap>& bitmaps);

@@ -192,6 +193,7 @@ void UpdateShortcutWorker::DownloadIcon() {

void UpdateShortcutWorker::DidDownloadFavicon(

int id,

+ int http_status_code,

const GURL& image_url,

int requested_size,

const std::vector<SkBitmap>& bitmaps) {