chrome/browser/notifications/message_center_notification_manager.h - Issue 14322023: Don't request missing favicon on every page request.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/message_center_notification_manager.h

Issue 14322023: Don't request missing favicon on every page request. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added TEST_F(FaviconHandlerTest, UnableToDownloadFavicon) Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/notifications/message_center_notification_manager.h

diff --git a/chrome/browser/notifications/message_center_notification_manager.h b/chrome/browser/notifications/message_center_notification_manager.h

index 2bd7a6f81d7fed45e9f105e6f81afe89764ee87d..b4510dbd440661197154d128a5cc9180f3bcff90 100644

--- a/chrome/browser/notifications/message_center_notification_manager.h

+++ b/chrome/browser/notifications/message_center_notification_manager.h

@@ -91,6 +91,7 @@ class MessageCenterNotificationManager

// FaviconHelper callback.

void DownloadComplete(const SetImageCallback& callback,

int download_id,

+ int http_status_code,

const GURL& image_url,

int requested_size,

const std::vector<SkBitmap>& bitmaps);