Don't request missing favicon on every page request.

chrome/browser/favicon/favicon_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_FAVICON_FAVICON_SERVICE_H_
 #define CHROME_BROWSER_FAVICON_FAVICON_SERVICE_H_
 
 #include <vector>
 
 #include "base/callback.h"
+#include "base/hash_tables.h"
 #include "base/memory/ref_counted.h"
 #include "chrome/browser/common/cancelable_request.h"
 #include "chrome/browser/history/history_types.h"
 #include "chrome/browser/profiles/profile_keyed_service.h"
 #include "chrome/common/cancelable_task_tracker.h"
 #include "chrome/common/ref_counted_util.h"
 #include "ui/base/layout.h"
 
 class GURL;
 class HistoryService;
@@ skipping 195 matching lines @@
   // MergeFavicon() if it does not.
   // TODO(pkotwicz): Save unresized favicon bitmaps to the database.
   // TODO(pkotwicz): Support adding favicons for multiple icon URLs to the
   // thumbnail database.
   void SetFavicons(
       const GURL& page_url,
       const GURL& icon_url,
       history::IconType icon_type,
       const gfx::Image& image);
 
+  // Avoid repeated requests to download missing favicon (crbug 39402).

[pauljensen, 2013/04/30 14:38:04]

The prevailing style is crbug.com/39402.

[mef, 2013/04/30 21:57:03]

Done.

+  void AddMissingFavicon(const GURL& icon_url);
+  bool IsMissingFavicon(const GURL& icon_url) const;
+
  private:
+  base::hash_set<int32>  missing_favicon_urls_;

[mef, 2013/04/29 21:55:03]

Lint suggests to add #include for hash_set<>, which appears to be hash_tables.h,
yet it is still unhappy.

[pauljensen, 2013/04/30 14:38:04]

Ya, I think lint is wrong and your code is correct.  I've run into this before.

[pauljensen, 2013/04/30 14:38:04]

You should not use int32.  The Google C++ coding style recommends the C99 types
like int32_t, though I see base::Hash returns an uint32.  The Chromium coding
style says to use unsigned types for hash values.  I would recommend typedef'ing
this because you use it in two different files.  Maybe:
  typedef uint32 MissingFaviconURLHashValue;
or maybe with a shorter name.

[mef, 2013/04/30 21:57:03]

Done.

[mef, 2013/04/30 21:57:03]

Done.

   HistoryService* history_service_;
 
   // Helper function for GetFaviconImageForURL(), GetRawFaviconForURL() and
   // GetFaviconForURL().
   CancelableTaskTracker::TaskId GetFaviconForURLImpl(
       const FaviconForURLParams& params,
       const std::vector<ui::ScaleFactor>& desired_scale_factors,
       const FaviconResultsCallback& callback,
       CancelableTaskTracker* tracker);
 
@@ skipping 12 matching lines @@
   void RunFaviconRawCallbackWithBitmapResults(
       const FaviconRawCallback& callback,
       int desired_size_in_dip,
       ui::ScaleFactor desired_scale_factor,
       const std::vector<history::FaviconBitmapResult>& favicon_bitmap_results);
 
   DISALLOW_COPY_AND_ASSIGN(FaviconService);
 };
 
 #endif  // CHROME_BROWSER_FAVICON_FAVICON_SERVICE_H_