Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: content/browser/web_contents/web_contents_impl.h

Issue 14322023: Don't request missing favicon on every page request. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Propagate HTTP Status Code to FaviconTabHelper::DidDownloadFavicon, Clear Missing Favicons on RELOA… Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 565 matching lines...) Expand 10 before | Expand all | Expand 10 after
576 const base::FilePath& path, 576 const base::FilePath& path,
577 bool is_hung); 577 bool is_hung);
578 void OnWebUISend(const GURL& source_url, 578 void OnWebUISend(const GURL& source_url,
579 const std::string& name, 579 const std::string& name,
580 const base::ListValue& args); 580 const base::ListValue& args);
581 void OnRequestPpapiBrokerPermission(int request_id, 581 void OnRequestPpapiBrokerPermission(int request_id,
582 const GURL& url, 582 const GURL& url,
583 const base::FilePath& plugin_path); 583 const base::FilePath& plugin_path);
584 void OnBrowserPluginMessage(const IPC::Message& message); 584 void OnBrowserPluginMessage(const IPC::Message& message);
585 void OnDidDownloadImage(int id, 585 void OnDidDownloadImage(int id,
586 int http_status_code,
586 const GURL& image_url, 587 const GURL& image_url,
587 int requested_size, 588 int requested_size,
588 const std::vector<SkBitmap>& bitmaps); 589 const std::vector<SkBitmap>& bitmaps);
589 void OnUpdateFaviconURL(int32 page_id, 590 void OnUpdateFaviconURL(int32 page_id,
590 const std::vector<FaviconURL>& candidates); 591 const std::vector<FaviconURL>& candidates);
591 void OnFrameDetached(int64 frame_id); 592 void OnFrameDetached(int64 frame_id);
592 593
593 // Changes the IsLoading state and notifies delegate as needed 594 // Changes the IsLoading state and notifies delegate as needed
594 // |details| is used to provide details on the load that just finished 595 // |details| is used to provide details on the load that just finished
595 // (but can be null if not applicable). Can be overridden. 596 // (but can be null if not applicable). Can be overridden.
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
895 // Maps the ids of pending image downloads to their callbacks 896 // Maps the ids of pending image downloads to their callbacks
896 typedef std::map<int, ImageDownloadCallback> ImageDownloadMap; 897 typedef std::map<int, ImageDownloadCallback> ImageDownloadMap;
897 ImageDownloadMap image_download_map_; 898 ImageDownloadMap image_download_map_;
898 899
899 DISALLOW_COPY_AND_ASSIGN(WebContentsImpl); 900 DISALLOW_COPY_AND_ASSIGN(WebContentsImpl);
900 }; 901 };
901 902
902 } // namespace content 903 } // namespace content
903 904
904 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 905 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698