Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: tools/pnacl-freeze/pnacl-freeze.cpp

Issue 14322020: Remove unnecessary includes from pnacl-freeze. (Closed) Base URL: http://git.chromium.org/native_client/pnacl-llvm.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/pnacl-freeze/pnacl-freeze.cpp
diff --git a/tools/pnacl-freeze/pnacl-freeze.cpp b/tools/pnacl-freeze/pnacl-freeze.cpp
index 1134dbdd5cec00b6417518b4ac890fb121f27396..df7bb9d7308261d4bf66a1d53bbf603fd666ad0c 100644
--- a/tools/pnacl-freeze/pnacl-freeze.cpp
+++ b/tools/pnacl-freeze/pnacl-freeze.cpp
@@ -11,29 +11,20 @@
//
//===----------------------------------------------------------------------===//
-#include "llvm/IR/LLVMContext.h"
jvoung - send to chromium... 2013/04/29 18:11:29 Don't you need LLVMContext.h for the LLVMContext i
Karl 2013/04/29 20:57:22 Apparently it is included from one of the other fi
-#include "llvm/Assembly/AssemblyAnnotationWriter.h"
// Note: We need the following to provide the API for calling the NaCl
// Bitcode Writer to generate the frozen file.
#include "llvm/Bitcode/NaCl/NaClReaderWriter.h"
// Note: We need the following to provide the API for calling the (LLVM)
// Bitcode Reader to read in the corresonding pexe file to freeze.
#include "llvm/Bitcode/ReaderWriter.h"
-#include "llvm/DebugInfo.h"
#include "llvm/IR/IntrinsicInst.h"
jvoung - send to chromium... 2013/04/29 18:11:29 do you need intrinsicinst.h?
Karl 2013/04/29 20:57:22 Guess I goofed in my testing. Not needed and remov
#include "llvm/IR/Module.h"
-#include "llvm/IR/Type.h"
#include "llvm/Support/CommandLine.h"
#include "llvm/Support/DataStream.h"
-#include "llvm/Support/FormattedStream.h"
#include "llvm/Support/ManagedStatic.h"
-#include "llvm/Support/MemoryBuffer.h"
#include "llvm/Support/PrettyStackTrace.h"
#include "llvm/Support/Signals.h"
#include "llvm/Support/ToolOutputFile.h"
-#include "llvm/Support/system_error.h"
-
-// llvm/Bitcode/BitstreamWriter.h
using namespace llvm;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698