Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14322020: Remove unnecessary includes from pnacl-freeze. (Closed)

Created:
7 years, 7 months ago by Karl
Modified:
7 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/pnacl-llvm.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M tools/pnacl-freeze/pnacl-freeze.cpp View 1 2 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Karl
PTAL. Thanks.
7 years, 7 months ago (2013-04-29 18:06:03 UTC) #1
jvoung - send to chromium...
https://codereview.chromium.org/14322020/diff/1001/tools/pnacl-freeze/pnacl-freeze.cpp File tools/pnacl-freeze/pnacl-freeze.cpp (left): https://codereview.chromium.org/14322020/diff/1001/tools/pnacl-freeze/pnacl-freeze.cpp#oldcode14 tools/pnacl-freeze/pnacl-freeze.cpp:14: #include "llvm/IR/LLVMContext.h" Don't you need LLVMContext.h for the LLVMContext ...
7 years, 7 months ago (2013-04-29 18:11:29 UTC) #2
Karl
https://codereview.chromium.org/14322020/diff/1001/tools/pnacl-freeze/pnacl-freeze.cpp File tools/pnacl-freeze/pnacl-freeze.cpp (left): https://codereview.chromium.org/14322020/diff/1001/tools/pnacl-freeze/pnacl-freeze.cpp#oldcode14 tools/pnacl-freeze/pnacl-freeze.cpp:14: #include "llvm/IR/LLVMContext.h" On 2013/04/29 18:11:29, jvoung wrote: > Don't ...
7 years, 7 months ago (2013-04-29 20:57:22 UTC) #3
jvoung (off chromium)
LGTM thanks!
7 years, 7 months ago (2013-04-29 21:00:23 UTC) #4
Karl
7 years, 7 months ago (2013-04-30 20:57:46 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 manually as r7332f61 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698