Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: cc/resources/picture.cc

Issue 14322017: Revert "cc: Move canvas clear from picture to picture_pile_impl" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/resources/picture_pile_impl.cc » ('j') | cc/resources/picture_pile_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/picture.cc
diff --git a/cc/resources/picture.cc b/cc/resources/picture.cc
index 199f94766b6c36336a77eb63016be4625ef3f0d3..b4dfbc45220c11a4ca303d5658645037dea0060b 100644
--- a/cc/resources/picture.cc
+++ b/cc/resources/picture.cc
@@ -167,15 +167,7 @@ void Picture::Record(ContentLayerClient* painter,
canvas->translate(SkFloatToScalar(-layer_rect_.x()),
SkFloatToScalar(-layer_rect_.y()));
- SkPaint paint;
- paint.setAntiAlias(false);
- paint.setXfermodeMode(SkXfermode::kClear_Mode);
- SkRect layer_skrect = SkRect::MakeXYWH(layer_rect_.x(),
- layer_rect_.y(),
- layer_rect_.width(),
- layer_rect_.height());
- canvas->clipRect(layer_skrect);
- canvas->drawRect(layer_skrect, paint);
+ canvas->clipRect(RectToSkRect(layer_rect_));
Tom Hudson 2013/04/30 09:43:59 Is this clip actually necessary, since we've creat
vmpstr 2013/04/30 17:06:23 I had it there initially, since I wasn't sure. But
gfx::RectF opaque_layer_rect;
base::TimeTicks begin_record_time;
« no previous file with comments | « no previous file | cc/resources/picture_pile_impl.cc » ('j') | cc/resources/picture_pile_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698