Issue 14322009: Sync FileSystem: Add default mock expectation for MockDriveService::GetChangeList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14322009: Sync FileSystem: Add default mock expectation for MockDriveService::GetChangeList (Closed)

Created:
7 years, 8 months ago by tzik

Modified:
7 years, 8 months ago

Reviewers:
calvinlo, kinaba

CC:
chromium-reviews, tfarina, kinuko+watch, tzik+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Sync FileSystem: Add default mock expectation for MockDriveService::GetChangeList BUG=173339 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194570

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -20 lines)			Patch
M	chrome/browser/google_apis/mock_drive_service.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/google_apis/mock_drive_service.cc	View	1	2 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/sync_file_system/drive_file_sync_service_mock_unittest.cc	View	1 2	7 chunks	+4 lines, -20 lines	0 comments	Download

Total messages: 6 (0 generated)

tzik

I'd like to add default mock expectation to avoid adding expectation for each test case ...

7 years, 8 months ago (2013-04-17 07:55:11 UTC) #1

tzik

On 2013/04/17 07:57:50, kinaba wrote: > lgtm calvin: I replaced the StrictMock of DriveService to ...

7 years, 8 months ago (2013-04-17 10:45:44 UTC) #4

tzik

7 years, 8 months ago (2013-04-17 11:15:06 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r194570 (presubmit successful).