Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypeResolverVisitor.java

Issue 14322008: Version 0.4.7.3 . (Closed) Base URL: http://dart.googlecode.com/svn/trunk/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypeResolverVisitor.java
===================================================================
--- editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypeResolverVisitor.java (revision 21601)
+++ editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypeResolverVisitor.java (working copy)
@@ -707,14 +707,20 @@
String name = typeName.getName().getName();
if (name.equals(dynamicKeyword)) {
reportError(CompileTimeErrorCode.IMPLEMENTS_DYNAMIC, typeName);
- } else if (typeName.getName().getElement().equals(classElement)) {
- reportError(CompileTimeErrorCode.IMPLEMENTS_SELF, typeName, name);
+ } else {
+ Element element = typeName.getName().getElement();
+ if (element != null && element.equals(classElement)) {
+ reportError(CompileTimeErrorCode.IMPLEMENTS_SELF, typeName, name);
+ }
}
if (!detectedRepeatOnIndex[i]) {
for (int j = i + 1; j < typeNames.length; j++) {
+ Element element = typeName.getName().getElement();
TypeName typeName2 = typeNames[j];
- String name2 = typeName2.getName().getName();
- if (typeName.getName().getElement().equals(typeName2.getName().getElement())) {
+ Identifier identifier2 = typeName2.getName();
+ String name2 = identifier2.getName();
+ Element element2 = identifier2.getElement();
+ if (element != null && element.equals(element2)) {
detectedRepeatOnIndex[j] = true;
reportError(CompileTimeErrorCode.IMPLEMENTS_REPEATED, typeName2, name2);
}

Powered by Google App Engine
This is Rietveld 408576698