Add line height setting to views::Label & use it for notifications.

ui/gfx/canvas_mac.mm

Index: ui/gfx/canvas_mac.mm
diff --git a/ui/gfx/canvas_mac.mm b/ui/gfx/canvas_mac.mm
index bb99c0666c28cb67352d07217eba3d01361bf633..6d8da995969e64751cd6e17074fc7b96159f3883 100644
--- a/ui/gfx/canvas_mac.mm
+++ b/ui/gfx/canvas_mac.mm
@@ -13,11 +13,10 @@
 #include "ui/gfx/rect.h"
 
 // Note: This is a temporary Skia-based implementation of the ui/gfx text
-// rendering routines for views/aura.  It replaces the stale Cocoa-based
-// implementation.  A future |canvas_skia.cc| implementation will supersede
-// this and the other platform-specific implmenentations.
-// Most drawing options, such as alignment and multi-line, are not implemented
-// here.
+// rendering routines for views/aura. It replaces the stale Cocoa-based
+// implementation. A future |canvas_skia.cc| implementation will supersede
+// this and the other platform-specific implmenentations. Most drawing options,
+// such as alignment, multi-line, and line heights are not implemented here.
 
 namespace {
 
@@ -40,6 +39,7 @@ void Canvas::SizeStringInt(const string16& text,
                            const gfx::Font& font,
                            int* width,
                            int* height,
+                           int line_height,

[msw, 2013/04/17 20:12:59]

nit: consider a DLOG_IF(WARNING, line_height != -1) << "Line heights are not
implemented."; here and below. You could also optionally add a similar check for
(flags & Canvas::MULTI_LINE)

[dharcourt, 2013/04/17 23:29:40]

Done.

                            int flags) {
   NSFont* native_font = font.GetNativeFont();
   NSString* ns_string = base::SysUTF16ToNSString(text);
@@ -55,6 +55,7 @@ void Canvas::DrawStringWithShadows(const string16& text,
                                    const gfx::Font& font,
                                    SkColor color,
                                    const gfx::Rect& text_bounds,
+                                   int line_height,
                                    int flags,
                                    const ShadowValues& shadows) {
   DLOG_IF(WARNING, !shadows.empty()) << "Text shadow not implemented.";