Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1937)

Unified Diff: build/android/pylib/forwarder.py

Issue 14322004: [Android] Fix forwarder for the component build (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: change distribution folder to fowarder_dist to avoid colliding with forwarder (1) Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/push_libraries.gypi ('k') | build/android/strip_native_libraries.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/forwarder.py
diff --git a/build/android/pylib/forwarder.py b/build/android/pylib/forwarder.py
index 5a527fe23225b7d8b620eb10c06b0d290f4fec0c..b808bfd5b52fa9b88ca13bc191740afc48bf0077 100644
--- a/build/android/pylib/forwarder.py
+++ b/build/android/pylib/forwarder.py
@@ -27,7 +27,11 @@ class Forwarder(object):
_DEVICE_ADB_CONTROL_PORT = 'chrome_device_forwarder'
_TIMEOUT_SECS = 30
- _DEVICE_FORWARDER_PATH = constants.TEST_EXECUTABLE_DIR + '/device_forwarder'
+ _DEVICE_FORWARDER_FOLDER = (constants.TEST_EXECUTABLE_DIR +
+ '/forwarder/')
+ _DEVICE_FORWARDER_PATH = (constants.TEST_EXECUTABLE_DIR +
+ '/forwarder/device_forwarder')
+ _LD_LIBRARY_PATH = 'LD_LIBRARY_PATH=%s' % _DEVICE_FORWARDER_FOLDER
def __init__(self, adb, build_type):
"""Forwards TCP ports on the device back to the host.
@@ -43,8 +47,8 @@ class Forwarder(object):
self._host_to_device_port_map = dict()
self._device_process = None
self._host_forwarder_path = _MakeBinaryPath(build_type, 'host_forwarder')
- self._device_forwarder_path = _MakeBinaryPath(
- build_type, 'device_forwarder')
+ self._device_forwarder_path_on_host = os.path.join(
+ cmd_helper.OutDirectory.get(), build_type, 'forwarder_dist')
def Run(self, port_pairs, tool, host_name):
"""Runs the forwarder.
@@ -67,7 +71,7 @@ class Forwarder(object):
if not host_adb_control_port:
raise Exception('Failed to allocate a TCP port in the host machine.')
self._adb.PushIfNeeded(
- self._device_forwarder_path, Forwarder._DEVICE_FORWARDER_PATH)
+ self._device_forwarder_path_on_host, Forwarder._DEVICE_FORWARDER_FOLDER)
redirection_commands = [
'%d:%d:%d:%s' % (host_adb_control_port, device, host,
host_name) for device, host in port_pairs]
@@ -81,8 +85,9 @@ class Forwarder(object):
raise Exception('Error while running adb forward.')
(exit_code, output) = self._adb.GetShellCommandStatusAndOutput(
- '%s %s %s' % (tool.GetUtilWrapper(), Forwarder._DEVICE_FORWARDER_PATH,
- Forwarder._DEVICE_ADB_CONTROL_PORT))
+ '%s %s %s %s' % (tool.GetUtilWrapper(), Forwarder._LD_LIBRARY_PATH,
+ Forwarder._DEVICE_FORWARDER_PATH,
+ Forwarder._DEVICE_ADB_CONTROL_PORT))
if exit_code != 0:
raise Exception(
'Failed to start device forwarder:\n%s' % '\n'.join(output))
« no previous file with comments | « build/android/push_libraries.gypi ('k') | build/android/strip_native_libraries.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698