Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Side by Side Diff: ipc/ipc_channel_proxy.cc

Issue 1432193002: Add std::unique_ptr conversions to scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: I wish my local build wasn't randomly broken Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ipc/ipc_channel_proxy.h" 5 #include "ipc/ipc_channel_proxy.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/location.h" 9 #include "base/location.h"
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
(...skipping 402 matching lines...) Expand 10 before | Expand all | Expand 10 after
413 413
414 if (create_pipe_now) { 414 if (create_pipe_now) {
415 // Create the channel immediately. This effectively sets up the 415 // Create the channel immediately. This effectively sets up the
416 // low-level pipe so that the client can connect. Without creating 416 // low-level pipe so that the client can connect. Without creating
417 // the pipe immediately, it is possible for a listener to attempt 417 // the pipe immediately, it is possible for a listener to attempt
418 // to connect and get an error since the pipe doesn't exist yet. 418 // to connect and get an error since the pipe doesn't exist yet.
419 context_->CreateChannel(factory.Pass()); 419 context_->CreateChannel(factory.Pass());
420 } else { 420 } else {
421 context_->ipc_task_runner()->PostTask( 421 context_->ipc_task_runner()->PostTask(
422 FROM_HERE, base::Bind(&Context::CreateChannel, 422 FROM_HERE, base::Bind(&Context::CreateChannel,
423 context_.get(), Passed(factory.Pass()))); 423 context_.get(), base::Passed(&factory)));
dcheng 2015/11/11 16:18:34 I didn't investigate why this triggers a compile e
424 } 424 }
425 425
426 // complete initialization on the background thread 426 // complete initialization on the background thread
427 context_->ipc_task_runner()->PostTask( 427 context_->ipc_task_runner()->PostTask(
428 FROM_HERE, base::Bind(&Context::OnChannelOpened, context_.get())); 428 FROM_HERE, base::Bind(&Context::OnChannelOpened, context_.get()));
429 429
430 did_init_ = true; 430 did_init_ = true;
431 OnChannelInit(); 431 OnChannelInit();
432 } 432 }
433 433
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
516 return channel->TakeClientFileDescriptor(); 516 return channel->TakeClientFileDescriptor();
517 } 517 }
518 #endif 518 #endif
519 519
520 void ChannelProxy::OnChannelInit() { 520 void ChannelProxy::OnChannelInit() {
521 } 521 }
522 522
523 //----------------------------------------------------------------------------- 523 //-----------------------------------------------------------------------------
524 524
525 } // namespace IPC 525 } // namespace IPC
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698