content/shell/browser/shell.cc - Issue 1432143002: Track where WebContents are created in order to better understand issue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell.cc

Issue 1432143002: Track where WebContents are created in order to better understand issue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/constrained_window/constrained_window_views.cc ('K') | « content/public/browser/web_contents_source.cc ('k') | extensions/browser/app_window/app_window_contents.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/shell.cc

diff --git a/content/shell/browser/shell.cc b/content/shell/browser/shell.cc

index 0e8b8b731fa333e89b3bdec3259aeb3cb2acc1e1..0b5d8d9c4772e14b73c7e3ae6fedd1784e9a19c7 100644

--- a/content/shell/browser/shell.cc

+++ b/content/shell/browser/shell.cc

@@ -20,6 +20,7 @@

#include "content/public/browser/render_widget_host.h"

#include "content/public/browser/web_contents.h"

#include "content/public/browser/web_contents_observer.h"

+#include "content/public/browser/web_contents_source.h"

#include "content/public/common/content_switches.h"

#include "content/public/common/renderer_preferences.h"

#include "content/public/common/webrtc_ip_handling_policy.h"

@@ -173,6 +174,7 @@ Shell* Shell::CreateNewWindow(BrowserContext* browser_context,

WebContents::CreateParams create_params(browser_context, site_instance);

create_params.initial_size = AdjustWindowSize(initial_size);

WebContents* web_contents = WebContents::Create(create_params);

+ WebContentsSource::CreateForWebContentsAndLocation(web_contents, FROM_HERE);

Shell* shell = CreateShell(web_contents, create_params.initial_size);

if (!url.is_empty())

shell->LoadURL(url);