content/browser/web_contents/web_contents_impl.cc - Issue 1432143002: Track where WebContents are created in order to better understand issue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1432143002: Track where WebContents are created in order to better understand issue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/constrained_window/constrained_window_views.cc ('K') | « components/guest_view/browser/guest_view_manager.cc ('k') | content/content_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index ece7e1b97295923f86a0c0ee107a3ed2e8007164..15683095a246eef03900b1fa1e059eab18df6db9 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -92,6 +92,7 @@

#include "content/public/browser/user_metrics.h"

#include "content/public/browser/web_contents_delegate.h"

#include "content/public/browser/web_contents_observer.h"

+#include "content/public/browser/web_contents_source.h"

#include "content/public/common/bindings_policy.h"

#include "content/public/common/browser_plugin_guest_mode.h"

#include "content/public/common/content_constants.h"

@@ -1783,6 +1784,7 @@ void WebContentsImpl::CreateNewWindow(

create_params.initial_size = GetContainerBounds().size();

new_contents = static_cast<WebContentsImpl*>(

WebContents::Create(create_params));

+ WebContentsSource::CreateForWebContentsAndLocation(new_contents, FROM_HERE);

} else {

new_contents = GetBrowserPluginGuest()->CreateNewGuestWindow(create_params);

}