Turn ArrayPush into a stub specialized on the elements kind and argc.

Turn ArrayPush into a stub specialized on the elements kind and argc.

BUG=
R=mvstanton@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=18696

[Toon Verwaest, 2014-01-20 13:07:14]

PTAL

[mvstanton, 2014-01-20 14:49:12]

Hi Toon, cupla questions.
--Michael

https://codereview.chromium.org/143213003/diff/150001/src/ia32/code-stubs-ia3...
File src/ia32/code-stubs-ia32.cc (right):

https://codereview.chromium.org/143213003/diff/150001/src/ia32/code-stubs-ia3...
src/ia32/code-stubs-ia32.cc:4459: __ j(greater, &attempt_to_grow_elements);
Could you write the !FLAG_inline_new case here, such that you go to label
call_builtin, otherwise label attempt_to_grow_elements. This way it's
symmetrical with the else (double) case, and avoids a duplicate
TailCallExternalReference statement.

https://codereview.chromium.org/143213003/diff/150001/src/ia32/code-stubs-ia3...
src/ia32/code-stubs-ia32.cc:4505: masm, DONT_TRACK_ALLOCATION_SITE, NULL);
Do we know that the array passed in is from the current native context?

https://codereview.chromium.org/143213003/diff/150001/src/ia32/code-stubs-ia3...
src/ia32/code-stubs-ia32.cc:4546: const int kAllocationDelta = 4;
ASSERT(kAllocationDelta >= argc);

https://codereview.chromium.org/143213003/diff/150001/src/ia32/code-stubs-ia3...
src/ia32/code-stubs-ia32.cc:4571: // We know the elements array is in new space
so we don't need the
How do we know the elements array is in new space?

[Toon Verwaest, 2014-01-20 16:14:37]

https://codereview.chromium.org/143213003/diff/150001/src/ia32/code-stubs-ia3...
File src/ia32/code-stubs-ia32.cc (right):

https://codereview.chromium.org/143213003/diff/150001/src/ia32/code-stubs-ia3...
src/ia32/code-stubs-ia32.cc:4505: masm, DONT_TRACK_ALLOCATION_SITE, NULL);
Good catch. We currently don't.

On 2014/01/20 14:49:13, mvstanton wrote:
> Do we know that the array passed in is from the current native context?

https://codereview.chromium.org/143213003/diff/150001/src/ia32/code-stubs-ia3...
src/ia32/code-stubs-ia32.cc:4546: const int kAllocationDelta = 4;
On 2014/01/20 14:49:13, mvstanton wrote:
> ASSERT(kAllocationDelta >= argc);

Done.

https://codereview.chromium.org/143213003/diff/150001/src/ia32/code-stubs-ia3...
src/ia32/code-stubs-ia32.cc:4571: // We know the elements array is in new space
so we don't need the
Line 4541 (etc.) checks that. It would have gone to the builtin if it wasn't at
the end of newspace.



On 2014/01/20 14:49:13, mvstanton wrote:
> How do we know the elements array is in new space?

[mvstanton, 2014-01-20 16:28:11]

OKay, LGTM.

[Toon Verwaest, 2014-01-20 17:09:34]

Committed patchset #3 manually as r18696 (presubmit successful).