Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: third_party/tcmalloc/chromium/src/maybe_threads.cc

Issue 14321006: Adds TCMalloc support for Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Dai's comments Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/tcmalloc/chromium/src/maybe_threads.cc
diff --git a/third_party/tcmalloc/chromium/src/maybe_threads.cc b/third_party/tcmalloc/chromium/src/maybe_threads.cc
index 15c8a23dcb3509549ef6b45531f2418e988a3cf5..87054d00039939d08411d602a03a3491ab92e86d 100644
--- a/third_party/tcmalloc/chromium/src/maybe_threads.cc
+++ b/third_party/tcmalloc/chromium/src/maybe_threads.cc
@@ -124,7 +124,9 @@ int perftools_pthread_once(pthread_once_t *ctl,
if (pthread_once) {
return pthread_once(ctl, init_routine);
} else {
- if (memcmp(ctl, &pthread_once_init, sizeof(*ctl)) == 0) {
+ if (memcmp((const void*)(ctl),
+ (const void*)(&pthread_once_init),
+ sizeof(*ctl)) == 0) {
Dai Mikurube (NOT FULLTIME) 2013/05/08 14:53:25 Ok, then let's use C++ style cast.
bulach 2013/05/08 16:09:10 :) it's a double-cast, and not entirely sure it'd
Dai Mikurube (NOT FULLTIME) 2013/05/09 16:29:28 wow, it's long, but I believe it's the better way.
init_routine();
++*(char*)(ctl); // make it so it's no longer equal to init
}

Powered by Google App Engine
This is Rietveld 408576698