Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: third_party/tcmalloc/chromium/src/base/commandlineflags.h

Issue 14321006: Adds TCMalloc support for Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Just my patch Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/tcmalloc/chromium/src/base/commandlineflags.h
diff --git a/third_party/tcmalloc/chromium/src/base/commandlineflags.h b/third_party/tcmalloc/chromium/src/base/commandlineflags.h
index 6c53bd29e4a2805013f8b6256e115f7a351c2bb4..d590ef20d296f9b30b968783a4467d38b884eb22 100644
--- a/third_party/tcmalloc/chromium/src/base/commandlineflags.h
+++ b/third_party/tcmalloc/chromium/src/base/commandlineflags.h
@@ -1,10 +1,10 @@
// Copyright (c) 2005, Google Inc.
// All rights reserved.
-//
+//
Dai Mikurube (NOT FULLTIME) 2013/05/03 08:53:00 nit: unnecessary deletion of whitespace
bulach 2013/05/07 14:55:51 my editor is configured to trim whitespaces automa
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
-//
+//
// * Redistributions of source code must retain the above copyright
// notice, this list of conditions and the following disclaimer.
// * Redistributions in binary form must reproduce the above
@@ -14,7 +14,7 @@
// * Neither the name of Google Inc. nor the names of its
// contributors may be used to endorse or promote products derived from
// this software without specific prior written permission.
-//
+//
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
@@ -121,7 +121,7 @@
#if defined(__ANDROID__) || defined(ANDROID)
-char g_system_property_value[PROP_VALUE_MAX];
+static char g_system_property_value[PROP_VALUE_MAX];
Dai Mikurube (NOT FULLTIME) 2013/05/03 08:53:00 It's not required with my recent patch.
bulach 2013/05/07 14:55:51 Done.
inline const char* EnvToString(const char* envname, const char* dflt) {
if (__system_property_get(envname, g_system_property_value) > 0)

Powered by Google App Engine
This is Rietveld 408576698