content/browser/android/web_contents_observer_proxy.h - Issue 1432083004: [Android WebView] Fire onPageFinished from WebContentsObserver::didStopLoading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/web_contents_observer_proxy.h

Issue 1432083004: [Android WebView] Fire onPageFinished from WebContentsObserver::didStopLoading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Restore required AwWebContentsObserverTest changes Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AwWebContentsObserverTest.java ('k') | content/browser/android/web_contents_observer_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/web_contents_observer_proxy.h

diff --git a/content/browser/android/web_contents_observer_proxy.h b/content/browser/android/web_contents_observer_proxy.h

index bbce0942241a030dc05f9a0ea2b9c01602da8e14..a366cfb77e0e70464edb2b86130af7890e22e1be 100644

--- a/content/browser/android/web_contents_observer_proxy.h

+++ b/content/browser/android/web_contents_observer_proxy.h

@@ -73,6 +73,7 @@ class WebContentsObserverProxy : public WebContentsObserver {

NavigationController::ReloadType reload_type) override;

void MediaSessionStateChanged(bool is_controllable,

bool is_suspended) override;

+ void SetToBaseURLForDataURLIfNeeded(std::string* url);

void DidFailLoadInternal(bool is_provisional_load,

bool is_main_frame,