Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1432063002: X87: [runtime] Drop redundant %CharFromCode runtime entry. (Closed)

Created:
5 years, 1 month ago by zhengxing.li
Modified:
5 years, 1 month ago
Reviewers:
Weiliang, chunyang.dai
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [runtime] Drop redundant %CharFromCode runtime entry. port 2b4cb2a14011404e7d20341bdc91d890a4584a18 (r31873) original commit message: The %StringCharFromCode and %CharFromCode runtime function perform exactly the same task, so we need only one of them. BUG= Committed: https://crrev.com/12a073e69a7631ba032d2e3996892c921481f420 Cr-Commit-Position: refs/heads/master@{#31909}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
zhengxing.li
5 years, 1 month ago (2015-11-10 02:01:32 UTC) #2
Weiliang
lgtm
5 years, 1 month ago (2015-11-10 02:06:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1432063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1432063002/1
5 years, 1 month ago (2015-11-10 02:06:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-10 02:25:19 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 02:25:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12a073e69a7631ba032d2e3996892c921481f420
Cr-Commit-Position: refs/heads/master@{#31909}

Powered by Google App Engine
This is Rietveld 408576698