Hide the fullscreen toolbar only for FramedBrowserWindow

chrome/browser/ui/cocoa/browser_window_controller_private.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/browser_window_controller_private.h"
 
 #include <cmath>
 
 #import "base/auto_reset.h"
 #include "base/command_line.h"
@@ skipping 82 matching lines @@
 }
 
 // Emits a histogram entry indicating the Fullscreen style.
 void RecordFullscreenStyle(FullscreenStyle style) {
   UMA_HISTOGRAM_ENUMERATION(
       "OSX.Fullscreen.Enter.Style", style, FULLSCREEN_STYLE_COUNT);
 }
 
 }  // namespace
 
+@interface NSWindow (NSPrivateApis)
+// Note: These functions are private, use -[NSObject respondsToSelector:]
+// before calling them.
+
+- (NSWindow*)_windowForToolbar;
+
+@end
+
 @implementation BrowserWindowController(Private)
 
 // Create the tab strip controller.
 - (void)createTabStripController {
   DCHECK([overlayableContentsController_ activeContainer]);
   DCHECK([[overlayableContentsController_ activeContainer] window]);
   tabStripController_.reset([[TabStripController alloc]
       initWithView:[self tabStripView]
         switchView:[overlayableContentsController_ activeContainer]
            browser:browser_.get()
@@ skipping 592 matching lines @@
   fullscreenTransition_.reset();
 
   // In Yosemite, some combination of the titlebar and toolbar always show in
   // full-screen mode. We do not want either to show. Search for the window that
   // contains the views, and hide it. There is no need to ever unhide the view.
   // http://crbug.com/380235
   if (base::mac::IsOSYosemiteOrLater()) {
     for (NSWindow* window in [[NSApplication sharedApplication] windows]) {
       if ([window
               isKindOfClass:NSClassFromString(@"NSToolbarFullScreenWindow")]) {
+        // Check if the window that the toolbar belongs to is a Chrome App
+        // window. If it is, then don't hide it.
+        if ([window respondsToSelector:@selector(_windowForToolbar)]) {
+          NSWindow* windowForToolbar = [window _windowForToolbar];
+          SEL selector = @selector(shouldHideFullscreenToolbar);

[erikchen, 2015/11/10 08:17:22]

If you're just trying to skip the Chrome App window, why don't you just check 
the class of the window, rather than adding the method
shouldHideFullscreenToolbar?

Alternatively, it seems cleaner to whitelist the window used by this class
(FramedBrowserWindow) by checking isKindOfClass? 

[spqchan, 2015/11/10 17:14:28]

Former: I did that earlier in Patch 2, please see the earlier messages in this
CL.
Latter: Sure, if all of the windows we want to hide the toolbar for is a
FramedBrowserWindow, then I can do that. Otherwise I think having that method
would be safer.

+          if ([windowForToolbar respondsToSelector:selector] &&
+              ![windowForToolbar performSelector:selector])
+            continue;
+        }
         [[window contentView] setHidden:YES];
       }
     }
   }
 
   if ([self shouldUseMavericksAppKitFullscreenHack]) {
     // Apply a hack to fix the size of the window. This is the last run of the
     // MessageLoop where the hack will not work, so dispatch the hack to the
     // top of the MessageLoop.
     base::Callback<void(void)> callback = base::BindBlock(^{
@@ skipping 467 matching lines @@
   return browser_->tab_strip_model()->GetActiveWebContents();
 }
 
 - (PermissionBubbleManager*)permissionBubbleManager {
   if (WebContents* contents = [self webContents])
     return PermissionBubbleManager::FromWebContents(contents);
   return nil;
 }
 
 @end  // @implementation BrowserWindowController(Private)