Issue 14320039: Make definition order match declaration order.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14320039: Make definition order match declaration order. (Closed)

Created:
7 years, 8 months ago by Peter Kasting

Modified:
7 years, 8 months ago

Reviewers:
joi

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Make definition order match declaration order. This minimizes the diff in https://codereview.chromium.org/14241006/ . BUG=none TEST=none TBR=joi Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195254

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -44 lines)			Patch
	M	chrome/browser/infobars/infobar_tab_helper.cc	View		2 chunks	+43 lines, -44 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

Joi, I'm TBRing this since it's a purely mechnical reorder to make the diff in ...

7 years, 8 months ago (2013-04-19 19:30:15 UTC) #1

joi

7 years, 8 months ago (2013-04-22 14:25:34 UTC) #3

LGTM

On Fri, Apr 19, 2013 at 7:32 PM,  <pkasting@chromium.org> wrote:
> Committed patchset #1 manually as r195254.
>
> https://codereview.chromium.org/14320039/

Expand Messages | Collapse Messages