Issue 14320035: Minor code cleanup of component updater.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14320035: Minor code cleanup of component updater. (Closed)

Created:
7 years, 8 months ago by xhwang

Modified:
7 years, 8 months ago

Reviewers:
cpu_(ooo_6.6-7.5), ddorwin

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -8 lines)			Patch
M	chrome/browser/component_updater/component_updater_service.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/component_updater/pepper_flash_component_installer.cc	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/component_updater/recovery_component_installer.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/component_updater/swiftshader_component_installer.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

xhwang

Just some nits I saw when I was working on the Widevine CDM installer. PTAL

7 years, 8 months ago (2013-04-19 17:23:48 UTC) #1

xhwang

7 years, 8 months ago (2013-04-22 05:31:02 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r195445 (presubmit successful).