Issue 14320030: Revert 195190 "Set up NaClChromeMainArgs number_of_cores member ..."

Issue 14320030: Revert 195190 "Set up NaClChromeMainArgs number_of_cores member ..." (Closed)

Created:
7 years, 8 months ago by szym

Modified:
7 years, 8 months ago

Reviewers:
bsy

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 195190 "Set up NaClChromeMainArgs number_of_cores member ..." > Set up NaClChromeMainArgs number_of_cores member so apps can size threadpools appropriately > > The outer sandbox on Linux and OSX was preventing > sysconf(_SC_NPROCESSORS_ONLN) from succeeding, so that NaCl > applications that need the number of threads were getting a > bogus value (-1 when using newlib, and 1 when using glibc). > > TEST= run_sysconf_nprocessors_onln_test > BUG=176522 > > Review URL: https://chromiumcodereview.appspot.com/14238013 TBR=bsy@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195213

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -262 lines)			Patch
M	trunk/src/chrome/nacl/nacl_helper_linux.cc	View	6 chunks	+4 lines, -8 lines	0 comments	Download
MM	trunk/src/chrome/nacl/nacl_listener.h	View	2 chunks	+0 lines, -15 lines	0 comments	Download
M	trunk/src/chrome/nacl/nacl_listener.cc	View	3 chunks	+0 lines, -8 lines	0 comments	Download
M	trunk/src/chrome/nacl/nacl_main.cc	View	2 chunks	+0 lines, -9 lines	0 comments	Download
M	trunk/src/chrome/test/data/nacl/nacl_test_data.gyp	View	1 chunk	+0 lines, -16 lines	0 comments	Download
D	trunk/src/chrome/test/data/nacl/sysconf_nprocessors_onln/sysconf_nprocessors_onln_test.cc	View	1 chunk	+0 lines, -108 lines	0 comments	Download
D	trunk/src/chrome/test/data/nacl/sysconf_nprocessors_onln/sysconf_nprocessors_onln_test.html	View	1 chunk	+0 lines, -59 lines	0 comments	Download
M	trunk/src/chrome/test/nacl/nacl_browsertest.cc	View	4 chunks	+0 lines, -39 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mark Seaborn

Why was it reverted? Please provide some explanation in revert commits.

7 years, 8 months ago (2013-04-19 16:22:19 UTC) #3

szym

On 2013/04/19 16:22:19, Mark Seaborn wrote: > Why was it reverted? Please provide some explanation ...

7 years, 8 months ago (2013-04-19 16:25:04 UTC) #4

bsy

7 years, 8 months ago (2013-04-19 16:59:32 UTC) #5

Message was sent while issue was closed.

On 2013/04/19 16:25:04, szym wrote:
> On 2013/04/19 16:22:19, Mark Seaborn wrote:
> > Why was it reverted?  Please provide some explanation in revert commits.
> 
> Sorry, that was sloppy of me.
> 
> The test immediately broke 6 Windows bots on the main waterfall.
> 
> There does not seem to be meaningful data in the logs:
>
http://build.chromium.org/p/chromium.win/builders/XP%2520Tests%2520%2528dbg%2...

thx.  i'll look into it

lgtm

Expand Messages | Collapse Messages