Issue 14320027: DevTools: Track CSSStyleSheetHeaders in the front-end real time

Issue 14320027: DevTools: Track CSSStyleSheetHeaders in the front-end real time (Closed)

Created:
7 years, 8 months ago by apavlov

Modified:
6 years, 10 months ago

Reviewers:
vsevik, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: Track CSSStyleSheetHeaders in the front-end real time BUG=233588 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148994

Patch Set 1 #

Total comments: 1

Patch Set 2 : Patch for landing #

Patch Set 3 : Patch for trybots (with [Slow]) #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+518 lines, -193 lines)			Patch
M	LayoutTests/TestExpectations	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
A	LayoutTests/inspector/styles/stylesheet-tracking.html	View	1	1 chunk	+179 lines, -0 lines	0 comments	Download
A	LayoutTests/inspector/styles/stylesheet-tracking-expected.txt	View	1	1 chunk	+36 lines, -0 lines	0 comments	Download
M	Source/core/dom/DocumentStyleSheetCollection.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/inspector/InspectorCSSAgent.h	View	1	5 chunks	+9 lines, -1 line	0 comments	Download
M	Source/core/inspector/InspectorCSSAgent.cpp	View	1	12 chunks	+133 lines, -32 lines	0 comments	Download
M	Source/core/inspector/InspectorInstrumentation.h	View	1	6 chunks	+14 lines, -0 lines	0 comments	Download
M	Source/core/inspector/InspectorInstrumentation.cpp	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/core/inspector/InspectorStyleSheet.h	View		2 chunks	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/CSSStyleModel.js	View		8 chunks	+101 lines, -101 lines	0 comments	Download
M	Source/devtools/front_end/SASSSourceMapping.js	View		1 chunk	+4 lines, -8 lines	0 comments	Download
M	Source/devtools/front_end/StylesSidebarPane.js	View		1 chunk	+5 lines, -11 lines	0 comments	Download
M	Source/devtools/front_end/StylesSourceMapping.js	View		2 chunks	+13 lines, -38 lines	0 comments	Download
M	Source/devtools/protocol.json	View	1	2 chunks	+15 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

apavlov

Please take a look. This is the patch that is pending review in the WebKit ...

7 years, 8 months ago (2013-04-19 15:48:57 UTC) #1

apavlov

https://codereview.chromium.org/14320027/diff/1/Source/devtools/front_end/CSSStyleModel.js File Source/devtools/front_end/CSSStyleModel.js (right): https://codereview.chromium.org/14320027/diff/1/Source/devtools/front_end/CSSStyleModel.js#newcode491 Source/devtools/front_end/CSSStyleModel.js:491: viaInspectorResourceForRule: function(rule) I'm happy to retain the callbacks and ...

7 years, 8 months ago (2013-04-19 15:50:19 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/14320027/1

7 years, 8 months ago (2013-04-22 15:11:51 UTC) #5

commit-bot: I haz the power

Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=4784

7 years, 8 months ago (2013-04-22 15:58:22 UTC) #6

apavlov

7 years, 8 months ago (2013-04-24 12:20:06 UTC) #7

Message was sent while issue was closed.

Committed patchset #3 manually as r148994 (presubmit successful).

Expand Messages | Collapse Messages