Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 14320024: Switch GCMole to use GYP build file instead of SCons. (Closed)

Created:
7 years, 8 months ago by Michael Starzinger
Modified:
7 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Switch GCMole to use GYP build file instead of SCons. R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14350

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -26 lines) Patch
M tools/gcmole/gcmole.lua View 2 chunks +13 lines, -19 lines 0 comments Download
M tools/gyp/v8.gyp View 7 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 8 months ago (2013-04-19 12:27:14 UTC) #1
Jakob Kummerow
I don't speak Lua, so: LGTM if it works :-)
7 years, 8 months ago (2013-04-19 12:44:56 UTC) #2
Michael Starzinger
7 years, 8 months ago (2013-04-19 12:46:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14350 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698