Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Side by Side Diff: Source/core/page/DeprecationAgent.h

Issue 14320022: Warn developers about deprecated features only once per page-load. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google, Inc. All rights reserved. 2 * Copyright (C) 2013 Google, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY GOOGLE INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY GOOGLE INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #ifndef WindowFocusAllowedIndicator_h 26 #ifndef DeprecationAgent_h
27 #define WindowFocusAllowedIndicator_h 27 #define DeprecationAgent_h
28 28
29 #include <wtf/BitVector.h>
29 #include <wtf/Noncopyable.h> 30 #include <wtf/Noncopyable.h>
30 #include <wtf/RefPtr.h> 31 #include <wtf/OwnPtr.h>
31 32
32 namespace WebCore { 33 namespace WebCore {
33 34
34 class WindowFocusAllowedIndicator { 35 class DOMWindow;
35 WTF_MAKE_NONCOPYABLE(WindowFocusAllowedIndicator); 36 class Document;
37 class PageConsole;
38
39 // DeprecationAgent is used to notify developers about the deprecation of APIs
40 // they make use of on pages. This notification would generally be the first
41 // step towards dropping support for a feature from Blink entirely.
42 //
43 // To notify developers that a feature they're making use of is deprecated:
44 //
45 // 1. Add the feature to the Feature enum below.
46 // 2. Add a deprecation message to DeprecationAgent.cpp.
47 // 3. Call DeprecationAgent::notify(FEATURE_TYPE, "Deprecation message.");
48 // 4. There is no step 4.
49
50 class DeprecationAgent {
pfeldman 2013/04/19 13:04:22 It is so small that it feels like deprecation coul
51 WTF_MAKE_NONCOPYABLE(DeprecationAgent);
36 public: 52 public:
37 WindowFocusAllowedIndicator(); 53 DeprecationAgent();
38 ~WindowFocusAllowedIndicator(); 54 ~DeprecationAgent();
39 55
40 static bool windowFocusAllowed(); 56 enum Feature {
57 PrefixedContentSecurityPolicyHeader,
58
59 // Add new features above this line.
60 NumberOfFeatures, // This enum value must be last.
61 };
62
63 static void notify(Document*, Feature);
41 64
42 private: 65 private:
43 bool m_previousWindowFocusAllowed; 66 void sendNotification(PageConsole*, Feature feature);
67
68 OwnPtr<BitVector> m_countBits;
44 }; 69 };
45 70
46 } // namespace WebCore 71 } // namespace WebCore
47 72
48 #endif // WindowFocusAllowedIndicator_h 73 #endif // DeprecationAgent_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698