Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 14320020: Initial restyle of the gallery. (Closed)

Created:
7 years, 8 months ago by mtomasz
Modified:
7 years, 8 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Initial restyle of the gallery. This patch introduces very basic restyle, which makes the gallery usable with the new ui. It addes the header which is draggable. This is quite tricky, since the header has to be outside of the iframe. -webkit-app-region: drag has no effect within an iframe. Along the way, a opacity animation has been added to thumbnails. TEST=Run with --file-manager-new-ui, click on a photo to get to the gallery. Try to move. BUG=233485 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195436

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased. #

Patch Set 3 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -6 lines) Patch
M chrome/browser/resources/file_manager/css/file_manager.css View 1 2 3 chunks +24 lines, -1 line 0 comments Download
M chrome/browser/resources/file_manager/css/gallery.css View 1 2 4 chunks +33 lines, -4 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager.js View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/js/photo/gallery.js View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/js/photo/ribbon.js View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/resources/file_manager/main_new_ui.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mtomasz
@yoshiki: PTAL. Thanks.
7 years, 8 months ago (2013-04-19 08:59:46 UTC) #1
yoshiki
lgtm with nit https://codereview.chromium.org/14320020/diff/1/chrome/browser/resources/file_manager/css/file_manager.css File chrome/browser/resources/file_manager/css/file_manager.css (right): https://codereview.chromium.org/14320020/diff/1/chrome/browser/resources/file_manager/css/file_manager.css#newcode1268 chrome/browser/resources/file_manager/css/file_manager.css:1268: -webkit-animation: fadeIn ease-in 1; nit: they ...
7 years, 8 months ago (2013-04-20 01:49:20 UTC) #2
mtomasz
https://codereview.chromium.org/14320020/diff/1/chrome/browser/resources/file_manager/css/file_manager.css File chrome/browser/resources/file_manager/css/file_manager.css (right): https://codereview.chromium.org/14320020/diff/1/chrome/browser/resources/file_manager/css/file_manager.css#newcode1268 chrome/browser/resources/file_manager/css/file_manager.css:1268: -webkit-animation: fadeIn ease-in 1; On 2013/04/20 01:49:20, yoshiki wrote: ...
7 years, 8 months ago (2013-04-22 02:51:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/14320020/7001
7 years, 8 months ago (2013-04-22 02:51:51 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, cacheinvalidation_unittests, chromedriver2_unittests, components_unittests, crypto_unittests, gpu_unittests, ...
7 years, 8 months ago (2013-04-22 03:53:10 UTC) #5
mtomasz
7 years, 8 months ago (2013-04-22 03:59:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r195436 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698