Issue 14320017: Revert 194991 "[Android] Fix null-build broken by https://codere..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14320017: Revert 194991 "[Android] Fix null-build broken by https://codere..." (Closed)

Created:
7 years, 8 months ago by nilesh

Modified:
7 years, 8 months ago

Reviewers:
Yaron

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 194991 "[Android] Fix null-build broken by https://codere..." Breaks the strip step. > [Android] Fix null-build broken by https://codereview.chromium.org/14322004/ > > The change unintentionally made the "always re-run strip" logic apply to > non-component build as well. Restored the original logic. > > BUG=158821 > NOTRY=true > > Review URL: https://chromiumcodereview.appspot.com/14057015 TBR=yfriedman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195092

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -17 lines)			Patch
	M	trunk/src/build/android/strip_native_libraries.gypi	View		2 chunks	+4 lines, -17 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r195092.