LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header-expected.txt - Issue 14320014: Make the WebSocket fail messages meaningful

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header-expected.txt

Issue 14320014: Make the WebSocket fail messages meaningful (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-no-cr-expected.txt ('k') | LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-prepended-null-expected.txt » ('j') | Source/modules/websockets/MainThreadWebSocketChannel.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header-expected.txt

diff --git a/LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header-expected.txt b/LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header-expected.txt

index 76aa03ca880622a3db02d4bf0133b8180b466370..8a5d5e47aba69b0d3b0821c881fe934dc4715fc2 100644

--- a/LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header-expected.txt

+++ b/LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header-expected.txt

@@ -1,4 +1,4 @@

-CONSOLE MESSAGE: WebSocket connection to 'ws://localhost:8880/websocket/tests/hybi/handshake-fail-by-no-upgrade-header' failed: Error during WebSocket handshake: 'Upgrade' header is missing

+CONSOLE MESSAGE: line 21: WebSocket connection to 'ws://localhost:8880/websocket/tests/hybi/handshake-fail-by-no-upgrade-header' failed: Error during WebSocket handshake: 'Upgrade' header is missing

Test that WebSocket handshake fails if Upgrade header field isn't reflected by the server.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".