Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 14320008: Fixes crash for operations on non-existing notifications. (Closed)

Created:
7 years, 8 months ago by Jun Mukai
Modified:
7 years, 8 months ago
Reviewers:
dewittj
CC:
chromium-reviews
Visibility:
Public.

Description

Fixes crash for operations on non-existing notifications. The widget's Close() will happen asynchronously and sometimes those operation can be called after the notification is removed. BUG=232895 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195299

Patch Set 1 #

Patch Set 2 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M ui/message_center/message_center_impl.cc View 1 5 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Jun Mukai
7 years, 8 months ago (2013-04-18 23:29:32 UTC) #1
Jun Mukai
ping?
7 years, 8 months ago (2013-04-19 18:25:24 UTC) #2
dewittj
lgtm
7 years, 8 months ago (2013-04-19 18:48:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/14320008/1
7 years, 8 months ago (2013-04-19 18:58:04 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-19 19:32:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/14320008/14001
7 years, 8 months ago (2013-04-19 20:43:10 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=119881
7 years, 8 months ago (2013-04-19 21:33:34 UTC) #7
Jun Mukai
7 years, 8 months ago (2013-04-19 21:56:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r195299 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698