Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: trunk/src/webkit/media/webmediaplayer_impl.h

Issue 14320005: Revert 194993 "Remove reference counting from media::VideoDecode..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/webkit/media/webkit_media.gypi ('k') | trunk/src/webkit/media/webmediaplayer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/webkit/media/webmediaplayer_impl.h
===================================================================
--- trunk/src/webkit/media/webmediaplayer_impl.h (revision 195011)
+++ trunk/src/webkit/media/webmediaplayer_impl.h (working copy)
@@ -272,10 +272,6 @@
// painted.
void FrameReady(const scoped_refptr<media::VideoFrame>& frame);
- // Builds a FilterCollection based on the current configuration of
- // WebMediaPlayerImpl.
- scoped_ptr<media::FilterCollection> BuildFilterCollection();
-
WebKit::WebFrame* frame_;
// TODO(hclam): get rid of these members and read from the pipeline directly.
@@ -289,6 +285,7 @@
// for DCHECKs so methods calls won't execute in the wrong thread.
const scoped_refptr<base::MessageLoopProxy> main_loop_;
+ scoped_ptr<media::FilterCollection> filter_collection_;
scoped_refptr<media::Pipeline> pipeline_;
base::Thread media_thread_;
@@ -332,9 +329,6 @@
bool incremented_externally_allocated_memory_;
- // Factories for supporting GpuVideoDecoder. May be null.
- scoped_refptr<media::GpuVideoDecoder::Factories> gpu_factories_;
-
// Routes audio playback to either AudioRendererSink or WebAudio.
scoped_refptr<WebAudioSourceProviderImpl> audio_source_provider_;
@@ -374,6 +368,8 @@
// not NULL while the compositor is actively using this webmediaplayer.
cc::VideoFrameProvider::Client* video_frame_provider_client_;
+ scoped_refptr<media::GpuVideoDecoder::Factories> gpu_factories_;
+
DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerImpl);
};
« no previous file with comments | « trunk/src/webkit/media/webkit_media.gypi ('k') | trunk/src/webkit/media/webmediaplayer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698