Issue 1431973002: Revert of Make LayoutImageResource::image() parameter explicit

Issue 1431973002: Revert of Make LayoutImageResource::image() parameter explicit (Closed)

Created:
5 years, 1 month ago by davve

Modified:
5 years, 1 month ago

Reviewers:
fs

CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Make LayoutImageResource::image() parameter explicit (patchset #2 id:20001 of https://codereview.chromium.org/1411693006/ ) Reason for revert: Seems to have caused 553045 Original issue's description: > Make LayoutImageResource::image() parameter explicit > > It makes the code more explicit and easier to read. No functional > change expected. > > BUG=551419 > > Committed: https://crrev.com/3059b983258e55aeacef6e0b04bdd35a72436d3b > Cr-Commit-Position: refs/heads/master@{#358287} TBR=fs@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=551419 Committed: https://crrev.com/20fa2832b2650a8654bfd8226561046760ebbfc9 Cr-Commit-Position: refs/heads/master@{#358551}

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -15 lines)			Patch
M	third_party/WebKit/Source/core/layout/LayoutImage.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/layout/LayoutImageResource.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/layout/LayoutImageResource.cpp	View	2 chunks	+1 line, -7 lines	0 comments	Download
M	third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/paint/ImagePainter.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/paint/SVGImagePainter.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

davve

Created Revert of Make LayoutImageResource::image() parameter explicit

5 years, 1 month ago (2015-11-08 15:33:22 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431973002/1

5 years, 1 month ago (2015-11-08 15:33:30 UTC) #2

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/20fa2832b2650a8654bfd8226561046760ebbfc9 Cr-Commit-Position: refs/heads/master@{#358551}

5 years, 1 month ago (2015-11-08 15:34:52 UTC) #4

davve

5 years, 1 month ago (2015-11-10 07:24:34 UTC) #5

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1431193004/ by davve@opera.com.

The reason for reverting is: Revert the revert. It looks like "Enable slimming
paint synchronized painting" was the culprit this time. Re-landing..

Expand Messages | Collapse Messages