Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Side by Side Diff: src/assembler.h

Issue 1431933003: [assembler] Introduce proper AssemblerBase::Print() for improved debuggability. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm64/disasm-arm64.cc ('k') | src/assembler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 // Overwrite a host NaN with a quiet target NaN. Used by mksnapshot for 93 // Overwrite a host NaN with a quiet target NaN. Used by mksnapshot for
94 // cross-snapshotting. 94 // cross-snapshotting.
95 static void QuietNaN(HeapObject* nan) { } 95 static void QuietNaN(HeapObject* nan) { }
96 96
97 int pc_offset() const { return static_cast<int>(pc_ - buffer_); } 97 int pc_offset() const { return static_cast<int>(pc_ - buffer_); }
98 98
99 // This function is called when code generation is aborted, so that 99 // This function is called when code generation is aborted, so that
100 // the assembler could clean up internal data structures. 100 // the assembler could clean up internal data structures.
101 virtual void AbortedCodeGeneration() { } 101 virtual void AbortedCodeGeneration() { }
102 102
103 // Debugging
104 void Print();
105
103 static const int kMinimalBufferSize = 4*KB; 106 static const int kMinimalBufferSize = 4*KB;
104 107
105 static void FlushICache(Isolate* isolate, void* start, size_t size); 108 static void FlushICache(Isolate* isolate, void* start, size_t size);
106 109
107 // TODO(all): Help get rid of this one. 110 // TODO(all): Help get rid of this one.
108 static void FlushICacheWithoutIsolate(void* start, size_t size); 111 static void FlushICacheWithoutIsolate(void* start, size_t size);
109 112
110 protected: 113 protected:
111 // The buffer into which code and relocation info are generated. It could 114 // The buffer into which code and relocation info are generated. It could
112 // either be owned by the assembler or be provided externally. 115 // either be owned by the assembler or be provided externally.
(...skipping 1160 matching lines...) Expand 10 before | Expand all | Expand 10 after
1273 std::vector<ConstantPoolEntry> shared_entries; 1276 std::vector<ConstantPoolEntry> shared_entries;
1274 }; 1277 };
1275 1278
1276 Label emitted_label_; // Records pc_offset of emitted pool 1279 Label emitted_label_; // Records pc_offset of emitted pool
1277 PerTypeEntryInfo info_[ConstantPoolEntry::NUMBER_OF_TYPES]; 1280 PerTypeEntryInfo info_[ConstantPoolEntry::NUMBER_OF_TYPES];
1278 }; 1281 };
1279 1282
1280 } // namespace internal 1283 } // namespace internal
1281 } // namespace v8 1284 } // namespace v8
1282 #endif // V8_ASSEMBLER_H_ 1285 #endif // V8_ASSEMBLER_H_
OLDNEW
« no previous file with comments | « src/arm64/disasm-arm64.cc ('k') | src/assembler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698