Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Side by Side Diff: src/sweeper-thread.cc

Issue 143193002: Move the temporary private freelist closer to where it's used (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/sweeper-thread.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 28 matching lines...) Expand all
39 39
40 SweeperThread::SweeperThread(Isolate* isolate) 40 SweeperThread::SweeperThread(Isolate* isolate)
41 : Thread(Thread::Options("v8:SweeperThread", kSweeperThreadStackSize)), 41 : Thread(Thread::Options("v8:SweeperThread", kSweeperThreadStackSize)),
42 isolate_(isolate), 42 isolate_(isolate),
43 heap_(isolate->heap()), 43 heap_(isolate->heap()),
44 collector_(heap_->mark_compact_collector()), 44 collector_(heap_->mark_compact_collector()),
45 start_sweeping_semaphore_(0), 45 start_sweeping_semaphore_(0),
46 end_sweeping_semaphore_(0), 46 end_sweeping_semaphore_(0),
47 stop_semaphore_(0), 47 stop_semaphore_(0),
48 free_list_old_data_space_(heap_->paged_space(OLD_DATA_SPACE)), 48 free_list_old_data_space_(heap_->paged_space(OLD_DATA_SPACE)),
49 free_list_old_pointer_space_(heap_->paged_space(OLD_POINTER_SPACE)), 49 free_list_old_pointer_space_(heap_->paged_space(OLD_POINTER_SPACE)) {
50 private_free_list_old_data_space_(heap_->paged_space(OLD_DATA_SPACE)),
51 private_free_list_old_pointer_space_(
52 heap_->paged_space(OLD_POINTER_SPACE)) {
53 NoBarrier_Store(&stop_thread_, static_cast<AtomicWord>(false)); 50 NoBarrier_Store(&stop_thread_, static_cast<AtomicWord>(false));
54 } 51 }
55 52
56 53
57 void SweeperThread::Run() { 54 void SweeperThread::Run() {
58 Isolate::SetIsolateThreadLocals(isolate_, NULL); 55 Isolate::SetIsolateThreadLocals(isolate_, NULL);
59 DisallowHeapAllocation no_allocation; 56 DisallowHeapAllocation no_allocation;
60 DisallowHandleAllocation no_handles; 57 DisallowHandleAllocation no_handles;
61 DisallowHandleDereference no_deref; 58 DisallowHandleDereference no_deref;
62 59
63 while (true) { 60 while (true) {
64 start_sweeping_semaphore_.Wait(); 61 start_sweeping_semaphore_.Wait();
65 62
66 if (Acquire_Load(&stop_thread_)) { 63 if (Acquire_Load(&stop_thread_)) {
67 stop_semaphore_.Signal(); 64 stop_semaphore_.Signal();
68 return; 65 return;
69 } 66 }
70 67
71 collector_->SweepInParallel(heap_->old_data_space(), 68 collector_->SweepInParallel(heap_->old_data_space(),
72 &private_free_list_old_data_space_,
73 &free_list_old_data_space_); 69 &free_list_old_data_space_);
74 collector_->SweepInParallel(heap_->old_pointer_space(), 70 collector_->SweepInParallel(heap_->old_pointer_space(),
75 &private_free_list_old_pointer_space_,
76 &free_list_old_pointer_space_); 71 &free_list_old_pointer_space_);
77 end_sweeping_semaphore_.Signal(); 72 end_sweeping_semaphore_.Signal();
78 } 73 }
79 } 74 }
80 75
81 76
82 intptr_t SweeperThread::StealMemory(PagedSpace* space) { 77 intptr_t SweeperThread::StealMemory(PagedSpace* space) {
83 if (space->identity() == OLD_POINTER_SPACE) { 78 if (space->identity() == OLD_POINTER_SPACE) {
84 return space->free_list()->Concatenate(&free_list_old_pointer_space_); 79 return space->free_list()->Concatenate(&free_list_old_pointer_space_);
85 } else if (space->identity() == OLD_DATA_SPACE) { 80 } else if (space->identity() == OLD_DATA_SPACE) {
(...skipping 23 matching lines...) Expand all
109 104
110 int SweeperThread::NumberOfThreads(int max_available) { 105 int SweeperThread::NumberOfThreads(int max_available) {
111 if (!FLAG_concurrent_sweeping && !FLAG_parallel_sweeping) return 0; 106 if (!FLAG_concurrent_sweeping && !FLAG_parallel_sweeping) return 0;
112 if (FLAG_sweeper_threads > 0) return FLAG_sweeper_threads; 107 if (FLAG_sweeper_threads > 0) return FLAG_sweeper_threads;
113 if (FLAG_concurrent_sweeping) return max_available - 1; 108 if (FLAG_concurrent_sweeping) return max_available - 1;
114 ASSERT(FLAG_parallel_sweeping); 109 ASSERT(FLAG_parallel_sweeping);
115 return max_available; 110 return max_available;
116 } 111 }
117 112
118 } } // namespace v8::internal 113 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/sweeper-thread.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698