Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 1431863004: Avoid merging SharedBuffer segments in TextResource::decodedText (Closed)

Created:
5 years, 1 month ago by kouhei (in TOK)
Modified:
5 years, 1 month ago
Reviewers:
Nate Chapin, tasak, tzik
CC:
chromium-reviews, blink-reviews, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid merging SharedBuffer segments in TextResource::decodedText Before this CL, TextResource could end up triggering costly SharedBuffer::mergeSegmentsIntoBuffer. This CL removes its call path by using progressive decoding. BUG=540988 Committed: https://crrev.com/cc4b7c65d7a702419f5a1f71057b3d3e6cb34d5b Cr-Commit-Position: refs/heads/master@{#358275}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M third_party/WebKit/Source/core/fetch/TextResource.cpp View 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kouhei (in TOK)
PTAL. I'll follow up with performance impact measurements result.
5 years, 1 month ago (2015-11-06 02:20:30 UTC) #2
tzik
lgtm
5 years, 1 month ago (2015-11-06 05:19:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431863004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431863004/1
5 years, 1 month ago (2015-11-06 05:50:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-06 06:55:17 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 06:55:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc4b7c65d7a702419f5a1f71057b3d3e6cb34d5b
Cr-Commit-Position: refs/heads/master@{#358275}

Powered by Google App Engine
This is Rietveld 408576698